Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup date-conversion-report.csv after test run #1178

Closed
blms opened this issue Oct 10, 2022 · 1 comment
Closed

Cleanup date-conversion-report.csv after test run #1178

blms opened this issue Oct 10, 2022 · 1 comment
Assignees
@rlskoeser
Labels
🛠️ chore One-off task or update

Comments

@blms
Copy link
Contributor

blms commented Oct 10, 2022

Normally I have to delete this file when running the full test suite. I believe it is caused by geniza/corpus/tests/test_convert_dates.py: test_convert_date_report.
@blms blms added the 🛠️ chore One-off task or update label Oct 10, 2022
rlskoeser added a commit that referenced this issue Oct 10, 2022
@rlskoeser
Use tmp path correctly for date conversion report #1178
9cda1b0
@rlskoeser
Copy link
Contributor

@blms I was using the tmp path object incorrectly! (still not really used to Path objects). Thanks for alerting me to the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlskoeser rlskoeser

Labels
🛠️ chore One-off task or update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlskoeser @blms