Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up after v4.9 release & tei migration #1179

Closed
4 tasks done
rlskoeser opened this issue Oct 10, 2022 · 6 comments
Closed
4 tasks done

clean up after v4.9 release & tei migration #1179

rlskoeser opened this issue Oct 10, 2022 · 6 comments
Assignees
Labels
🛠️ chore One-off task or update

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Oct 10, 2022

  • add more content to readme for pgp-text repo
  • remove content field from footnotes
  • remove sync transcription and tei migration code
  • remove iiif-bodleian-a repo in geniza lab github org
@rlskoeser
Copy link
Contributor Author

I'm reverting this cleanup — I did it too quickly, it looks like we need the tei migration code to stick around a little longer to help with cleaning up some problems found after migration (we have at least one case where the TEI had the wrong id, and it seems easiest to just rename the file and migrate it so it gets attached to the correct PGPID)

@rlskoeser rlskoeser reopened this Oct 14, 2022
@rlskoeser rlskoeser removed this from the CDH/PGP end of grant year 2 milestone Nov 21, 2022
@richmanrachel
Copy link

@blms - should this be closed?

@blms
Copy link
Contributor

blms commented Jan 24, 2024

Not sure @richmanrachel, I'm not using the TEI migration script anymore so maybe it can be removed and the issue closed. Thoughts @rlskoeser?

@rlskoeser
Copy link
Contributor Author

I hope we're not still using it at this point! based on my notes I removed and then put it back? so let's remove the old code and then close this. @blms is that appropriate for you to handle?

@blms
Copy link
Contributor

blms commented Feb 2, 2024

Yes I can do that @rlskoeser!

@blms
Copy link
Contributor

blms commented Feb 2, 2024

Done!

@blms blms closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

4 participants