Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a content editor, I want commit messages for transcription export data on GitHub to include PGPID so that I can more easily find the changes I'm interested in. #1187

Closed
rlskoeser opened this issue Oct 11, 2022 · 1 comment
Closed

As a content editor, I want commit messages for transcription export data on GitHub to include PGPID so that I can more easily find the changes I'm interested in. #1187

rlskoeser opened this issue Oct 11, 2022 · 1 comment
Assignees
@rlskoeser
Milestone
CDH/PGP end of gr...

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Oct 11, 2022 •
edited

testing notes

Modify a transcription on the test site, wait ~5 minutes, then check that the commit on the test github export includes the PGPID of the document you were working on:
https://github.com/Princeton-CDH/test-pgp-annotations/commits/migration-test-run

question: is the repeated PGP - PGPID redundant? any suggestions for revising?
@rlskoeser rlskoeser added the 🛠️ chore One-off task or update label Oct 11, 2022
@rlskoeser rlskoeser added this to the CDH/PGP end of grant year 2 milestone Oct 11, 2022
@rlskoeser rlskoeser changed the title annotation export git commit should include PGPID when possible As a content editor, I want commit messages for transcription export data on GitHub to include PGPID so that I can more easily find the changes I'm interested in. Oct 11, 2022
@rlskoeser rlskoeser removed the 🛠️ chore One-off task or update label Oct 11, 2022
rlskoeser added a commit that referenced this issue Oct 11, 2022
@rlskoeser
Include PGPID in git commit message for incremental annotation exports
e443808 
ref #1187
@rlskoeser rlskoeser mentioned this issue Oct 11, 2022
Merged
@rlskoeser rlskoeser self-assigned this Oct 11, 2022
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Oct 11, 2022
@mrustow
Copy link

mrustow commented Oct 12, 2022

It worked!
image
The PGP - PGPID redundancy doesn't bother me at all.

@mrustow mrustow closed this as completed Oct 12, 2022
@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlskoeser rlskoeser

Labels
None yet
Projects
None yet
Milestone
CDH/PGP end of grant year 2
Development

No branches or pull requests
2 participants
@rlskoeser @mrustow