Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Arabic and inline type styles in transcriptions #1194

Closed
5 tasks done
blms opened this issue Oct 12, 2022 · 2 comments
Closed
5 tasks done

Apply Arabic and inline type styles in transcriptions #1194

blms opened this issue Oct 12, 2022 · 2 comments
Assignees
Labels
🛠️ chore One-off task or update

Comments

@blms
Copy link
Contributor

blms commented Oct 12, 2022

Testing notes (QA)

On the public QA site:

  • For a document with an Arabic transcription, confirm the transcription has the new Arabic type styles (Amiri font)
  • Edit a transcription to add bits of Arabic script inline in the middle of a Hebrew transcription, and vice versa. Mark them up with the appropriate language using the "language" markup tool in the text editor (the globe icon).
  • Save, and confirm you see the fonts applied correctly (Amiri for Arabic inside Hebrew, and Frank Ruhl for Hebrew inside Arabic).
  • Confirm there is no visible decimal point or stray pixels next to line numbers.

dev notes

  • Apply type styles based on primary language (already done for Hebrew but not Arabic)
  • Apply type styles for inline language tags
  • Nudge the dot cover
@blms blms added the 🛠️ chore One-off task or update label Oct 12, 2022
@blms blms self-assigned this Oct 12, 2022
rlskoeser added a commit that referenced this issue Oct 14, 2022
…n-styles

Transcription styles (#1194) and admin fixes (#1193, #1202)
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Oct 18, 2022
@kseniaryzhova
Copy link

@blms @rlskoeser I do see these decimals on the transcription display in both public and admin
image

@kseniaryzhova kseniaryzhova added ⚠️ tested needs attention Has been through acceptance testing and needs additional work and removed 🗜️ awaiting testing Implemented and ready to be tested labels Oct 24, 2022
@rlskoeser
Copy link
Contributor

Closing this based on the primary functionality passing tests; should not have been kept open for the small display issue. If that remains an issue we can open a new ticket to investigate.

@rlskoeser rlskoeser removed the ⚠️ tested needs attention Has been through acceptance testing and needs additional work label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

3 participants