Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newly assigned ISSN to footer #1195

Closed
rlskoeser opened this issue Oct 12, 2022 · 1 comment
Closed

Add newly assigned ISSN to footer #1195

rlskoeser opened this issue Oct 12, 2022 · 1 comment
Assignees
@blms
Labels
🛠️ chore One-off task or update
Milestone
CDH/PGP end of gr...

Comments

@rlskoeser
Copy link
Contributor

ISSN: 2834-4146

There isn't a placeholder for it in our existing PGP footer designs, but please do something similar to what we did in the S&co footer, which was implemented based on Gissoo's advice (check both mobile and desktop versions). https://shakespeareandco.princeton.edu/
@rlskoeser rlskoeser added this to the CDH/PGP end of grant year 2 milestone Oct 12, 2022
@rlskoeser rlskoeser added the 🛠️ chore One-off task or update label Oct 12, 2022
blms added a commit that referenced this issue Oct 13, 2022
@blms
Add ISSN to footer (#1195)
d845b04
blms added a commit that referenced this issue Oct 13, 2022
@blms
Footer styles and fixes for RTL (#1195)
55e049c
blms added a commit that referenced this issue Oct 13, 2022
@blms
sw-version on mobile, tap target resize (#1195)
3e8d64b
@blms blms mentioned this issue Oct 13, 2022
Merged
blms added a commit that referenced this issue Oct 13, 2022
@blms
Add comment about sw-version tap-target (#1195)
e122b11 
[run percy]
blms added a commit that referenced this issue Oct 14, 2022
@blms
Regenrate translation files (#1195)
842e3c0
blms added a commit that referenced this issue Oct 14, 2022
@blms
Fix paths for translation files (#1195)
f65b933
blms added a commit that referenced this issue Oct 14, 2022
@blms
Merge pull request #1205 from Princeton-CDH/feature/1195-issn
343adfd 
Add ISSN to footer (#1195)
@rlskoeser
Copy link
Contributor Author

confirmed the new ISSN is present on the footer on the test site and looks good in both desktop and mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blms blms

Labels
🛠️ chore One-off task or update
Projects
None yet
Milestone
CDH/PGP end of grant year 2
Development

No branches or pull requests
2 participants
@rlskoeser @blms