Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transcriptions can be orphaned or lost when merging records #1207

Closed
kseniaryzhova opened this issue Oct 14, 2022 · 1 comment
Closed

transcriptions can be orphaned or lost when merging records #1207

kseniaryzhova opened this issue Oct 14, 2022 · 1 comment
Labels
🐛 bug Something isn't working performant Tasks for or taken on by Performant

Comments

@kseniaryzhova
Copy link

kseniaryzhova commented Oct 14, 2022

Describe the bug
Two PGPIDs (799 and 801) had two transcriptions for the same document (one from Gil, the other from Goitein). When merging the two records in production, Goitein's transcription did not merge properly. The document detail page was showing that there were two transcriptions, but Goitein's had no text in either the editor or the display.

Expected behavior
When merging two records for the same document, I want everything from both records (including transcriptions) to be present in the newly-merged PGPID.

Additional context
@rlskoeser fixed this by going into the python console and updating the manifest ID to point to the right document BUT we will need this feature for future data cleanup.

dev notes

Logic probably needs to go in Document._merge_footnotes — if any of the footnotes being merged are digital editions with transcription content, the code needs to look for corresponding annotations and update the manifest id in the record. (Right now annotations are related via uris and not foreign keys, but we may want to revisit that — should keep the merge code in mind when we do, since the logic could be impacted by this change.)

@kseniaryzhova kseniaryzhova added the 🐛 bug Something isn't working label Oct 14, 2022
@rlskoeser rlskoeser changed the title Partial loss of transcriptions when merging records transcriptions can be orphaned or lost when merging records Nov 8, 2022
@kseniaryzhova kseniaryzhova added the performant Tasks for or taken on by Performant label Nov 23, 2022
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Dec 16, 2022
@kseniaryzhova
Copy link
Author

@rlskoeser it works really well! Woo! Thank you!

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working performant Tasks for or taken on by Performant
Projects
None yet
Development

No branches or pull requests

3 participants