Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise annotation model to link footnotes using foreign keys instead of URIs #1238

Closed
16 tasks done
blms opened this issue Nov 16, 2022 · 2 comments
Closed
16 tasks done
Assignees
Labels
Epic performant Tasks for or taken on by Performant

Comments

@blms
Copy link
Contributor

blms commented Nov 16, 2022

Testing notes

On the QA admin site:

  • Check a few random transcriptions and confirm they are still present/accessible.
  • Check Log Entries for new footnotes added by the "script" user on Dec. 16, 2022, 2:16 pm. Click on some of the footnote objects: they should be "digital edition" footnotes with associated transcription content.
    • Go to the document they belong to (PGPID/title should be in the "Content object" field) and confirm the digital edition for that author/source has transcription content (i.e. using Edit X's Edition, or the dropdown menu above the transcription text)
    • On that document page, scroll down to the Footnotes section. Locate the digital edition footnote for the transcription you were just looking at, and check the "delete" box next to it at the far right end of the table. Click "save" at the bottom of the document page and confirm you get an error message, telling you that you can't delete a footnote with associated annotations here.

On the QA public site:

  • Check a few random transcriptions and confirm they are still visible on the public site; try editing them and confirm they show up in the editor too. (note: recent beta-tested editor fixes are not present on the site yet)

Please also test:

dev notes

Epic to collect related or affected bugs/chores.

Initial steps:

  • revise annotation model to add FK to footnote
  • data migration to associate existing footnotes + annotations explicitly
    • if digital edition footnote cannot be found but source and document can, then create new digital edition (with LogEntry)
    • generate report of any remaining problem annotations
  • if you delete a footnote from the document edit page, warn or prevent deletion
  • revise from json code to set footnote based on source + manifest uri when saving
  • revise to json code to serialize source & manifest uri when displaying
  • update annotation search methods
  • move signal handler footnote code into annotation view methods
  • everywhere we are looking up documents/sources by uri, we now get them by model accessors
  • Add Annotation Footnote prefetching to indexing query and data export query #1279
  • Decided not to do this to avoid altering Tahqiq: remove Document.from_manifest_uri, Document.id_from_manifest_uri, Source.from_uri, and Source.id_from_uri and replace all usage with lookups on Footnote
@blms blms added the Epic label Nov 16, 2022
@blms blms self-assigned this Nov 16, 2022
blms added a commit that referenced this issue Nov 17, 2022
blms added a commit that referenced this issue Nov 17, 2022
blms added a commit that referenced this issue Nov 17, 2022
- Update migration to remove reporting
- Delete dc:source and manifest URI keys from annotations
ref #1238
blms added a commit that referenced this issue Nov 21, 2022
blms added a commit that referenced this issue Nov 22, 2022
blms added a commit that referenced this issue Nov 22, 2022
also remove unnecessary f-string
blms added a commit that referenced this issue Dec 16, 2022
…ootnote

Revise annotation model to associate directly with footnotes (#1238)
blms added a commit that referenced this issue Dec 16, 2022
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Dec 16, 2022
@blms
Copy link
Contributor Author

blms commented Dec 16, 2022

Here is a list of known "digital editions" without transcription content:

Digital editions without annotations
  • Digital Edition of Bodl. MS heb. c 28/6 (PGPID 547). Source: Jacob Mann, The Jews in Egypt and in Palestine under the Fâtịmid Caliphs (1970), vol. 2.
  • Digital Edition of T-S 10J19.9 (PGPID 2944). Source: Moshe Gil, In the Kingdom of Ishmael‎ (in Hebrew) (1997), vol. 3.
  • Digital Edition of T-S 8.168 + ENA 4011.54 (PGPID 3658). Source: S. D. Goitein, unpublished editions. (ENA)
  • Digital Edition of T-S J2.66 (PGPID 6039). Source: A. L. Udovitch.
  • Edition and Digital Edition of BL OR 5547.1 (PGPID 6235). Source: Yusuf Umrethwala, Athina Pfeiffer and Alan Elbaum, (in Arabic) (2022).
  • Digital Edition of BL OR 5566B.1 (PGPID 6254). Source: Yusuf Umrethwala and Alan Elbaum, (in Arabic) (2022).
  • Edition and Translation and Digital Edition of BL OR 5566B.19 (PGPID 6266). Source: Marina Rustow and Alan Elbaum, (in Arabic) (2022).
  • Digital Edition of Bodl. MS heb. c 28/10 (PGPID 9545). Source: Alan Elbaum, (2022).
  • Translation and Digital Edition of Bodl. MS heb. d 81/19–22 (PGPID 19470). Source: Marina Rustow, Alan Elbaum and Yusuf Umrethwala, (in Arabic) (2022).
  • Digital Edition of T-S NS 137.29 (PGPID 23634). Source: Yusuf Umrethwala and Alan Elbaum, (in Arabic) (2022).
  • Edition and Digital Edition of T-S NS 207.57 (PGPID 23940). Source: Yusuf Umrethwala and Alan Elbaum, (in Arabic) (2022).
  • Edition and Digital Edition of AIU XII.80 (PGPID 29488). Source: Ṣabīḥ ʿAodeh, Eleventh Century Arabic Letters of Jewish Merchants from the Cairo Geniza‎ (in Hebrew) (1992).
  • Digital Edition of AIU XII.84 (PGPID 30995). Source: Yusuf Umrethwala, Matthew Dudley and Alan Elbaum, (in Arabic).
  • Digital Edition of Bodl. MS heb. b 11/7 (PGPID 31694). Source: Marina Rustow.
  • Digital Edition of ENA 3700.1 (PGPID 32749). Source: Yusuf Umrethwala, (in Arabic) (2022).
  • Digital Edition of NLI 577.1/75 (PGPID 33664). Source: Yusuf Umrethwala, (in Arabic) (2022).
  • Digital Edition of JRL SERIES P 213 (PGPID 34440). Source: Alan Elbaum and Marina Rustow, Unpublished editions (2022).
  • Edition and Digital Edition of BL OR 5557B.1 (PGPID 35188). Source: Marina Rustow, Alan Elbaum and Yusuf Umrethwala, (in Arabic) (2022).
  • Digital Edition of ENA NS I.72 (PGPID 35825). Source: Yusuf Umrethwala and Alan Elbaum, (in Arabic) (2022).
  • Digital Edition of ENA NS 13.15 (PGPID 36027). Source: Marina Rustow, Alan Elbaum and Yusuf Umrethwala, (in Arabic) (2022).
  • Digital Edition of Bod. MS Heb. g 2/60–67 (PGPID 36479). Source: Yusuf Umrethwala, (in Arabic) (2022).
  • Digital Edition of CUL Or. 1080 3.17 (PGPID 36489). Source: Marina Rustow, Alan Elbaum and Yusuf Umrethwala, (in Arabic) (2022).
  • Digital Edition of BL OR 5557K.9 (PGPID 36498). Source: Yusuf Umrethwala and Alan Elbaum, (in Arabic) (2022).
  • Digital Edition of BL Or. 5557K.11 (PGPID 36509). Source: Yusuf Umrethwala and Alan Elbaum, (in Arabic) (2022).
  • Digital Edition of Moss. IXa,2.47 (PGPID 36528). Source: Yusuf Umrethwala and Alan Elbaum, (in Arabic) (2022).

@kseniaryzhova
Copy link

@blms looks good, thank you! Closing!

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Dec 19, 2022
@rlskoeser rlskoeser added the performant Tasks for or taken on by Performant label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic performant Tasks for or taken on by Performant
Projects
None yet
Development

No branches or pull requests

3 participants