Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transcription labels in search results are RTL #1216

Closed
rlskoeser opened this issue Oct 26, 2022 · 1 comment
Closed

transcription labels in search results are RTL #1216

rlskoeser opened this issue Oct 26, 2022 · 1 comment
Assignees
@rlskoeser
Labels
🐛 bug Something isn't working

Comments

@rlskoeser
Copy link
Contributor

transcription labels in search results are inheriting the RTL text direction we have set on the transcription block; we should exempt them (which we already do on the document detail view)

Screen Shot 2022-10-26 at 4 20 23 PM
@rlskoeser rlskoeser added the 🐛 bug Something isn't working label Oct 26, 2022
@kseniaryzhova kseniaryzhova added the performant Tasks for or taken on by Performant label Nov 23, 2022
@rlskoeser rlskoeser removed the performant Tasks for or taken on by Performant label Dec 7, 2022
@rlskoeser rlskoeser self-assigned this Dec 7, 2022
rlskoeser added a commit that referenced this issue Dec 7, 2022
@rlskoeser
Fix rtl transcription labels #1216; more consistent text direction
274b3ef
@rlskoeser rlskoeser mentioned this issue Dec 7, 2022
Merged
rlskoeser added a commit that referenced this issue Dec 7, 2022
@rlskoeser
Fix rtl transcription labels #1216; more consistent text direction
8de45e3
rlskoeser added a commit that referenced this issue Dec 7, 2022
@rlskoeser
Fix rtl transcription labels #1216; more consistent text direction
b00b44b
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Dec 7, 2022
@kseniaryzhova
Copy link

@rlskoeser transcription labels seem LTR aligned to me - punctuation is where it should be, etc. Closing!

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlskoeser rlskoeser

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlskoeser @kseniaryzhova