Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some JRL images not displaying correctly #1288

Closed
kseniaryzhova opened this issue Jan 9, 2023 · 4 comments
Closed

Some JRL images not displaying correctly #1288

kseniaryzhova opened this issue Jan 9, 2023 · 4 comments
Assignees
Labels
🐛 bug Something isn't working performant Tasks for or taken on by Performant

Comments

@kseniaryzhova
Copy link

kseniaryzhova commented Jan 9, 2023

Testing notes

On the QA site, visit a document where both sides used to be marked "recto", such as PGPID 28296. It should now have the second image marked "verso".


Describe the bug
Some JRL images are displaying with two distinct issues:

Many JRL images are displaying correctly, so this does not affect the whole collection.

To reproduce
Steps to reproduce the behavior:

  1. See above examples, but also try searching by the JRL collection with images in admin and looking through some of the shelfmarks and how the images display in the editor.

Expected behavior
I want each JRL fragment to display accurately-labelled images of the recto and verso.

Additional context
RSK suggests revising the jrl_iiif.py script to override labels for verso

@kseniaryzhova kseniaryzhova added 🐛 bug Something isn't working performant Tasks for or taken on by Performant labels Jan 9, 2023
@blms blms self-assigned this Jan 9, 2023
@kseniaryzhova
Copy link
Author

Looked into the shelfmarks that are displaying only one image (so far it's JRL Gaster ar. 1, 11, 111, and 124). Their versos are visible on FGP, but are not visible on Manchester's site (via LUNA), probably because the versos on all of these documents are completely blank. This is a Manchester issue, since we get our IIIF manifests from their site and cannot display images that aren't there.

@blms
Copy link
Contributor

blms commented Jan 12, 2023

@kseniaryzhova The recto / recto problem is also something on Manchester's end—here's the fragment you linked. Should we ignore their label and always relabel the second image in a sequence (assuming 2 images) as verso?

@kseniaryzhova
Copy link
Author

@blms Yes assume the second fragment is a verso and ignore the label from Manchester.

@kseniaryzhova
Copy link
Author

@blms works well for this one example I found! (I looked at some other JRL images too and they are displaying recto/verso as they should). Thanks, closing!

@blms blms removed the 🗜️ awaiting testing Implemented and ready to be tested label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working performant Tasks for or taken on by Performant
Projects
None yet
Development

No branches or pull requests

2 participants