Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a public site viewer, I would like to see translation alongside the document image by default if both are present, so that I can read the document in my native language. #1400

Closed
6 tasks done
kseniaryzhova opened this issue Jun 21, 2023 · 1 comment
Assignees
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant

Comments

@kseniaryzhova
Copy link

kseniaryzhova commented Jun 21, 2023

testing notes (QA)

On the QA public site:

  • Find some documents with transcriptions, translations, and images. Translations should be open by default alongside images
    • Edit a transcription on one of these documents. The translation should now be collapsed by default, but expandable. (Vice versa for editing a translation)
  • Find some documents with transcriptions and translations, but no images. Images panel should be disabled; transcription and translation should be open by default
    • Editing either transcription or translation on these documents should use placeholder images, and images and the kind of content you are editing should still be open
  • Find some documents with other combinations of images, transcriptions, and translations, and ensure all still works as expected
  • all this should also be true on the admin site (after hard refresh)

Describe the solution you'd like
If there is a translation present for a document, it should be the first thing viewers see on both admin and the public site, accompanied by the document image (if that too is available). The language of the website (Hebrew/English) should determine which language of translation is visible (if more than one translation exists in the PGP)

@kseniaryzhova kseniaryzhova added 🆕 enhancement New feature or request performant Tasks for or taken on by Performant labels Jun 21, 2023
@blms blms changed the title Translation (if present) should appear in the viewer by default alongside the document image (if present) As a public site viewer, I would like to see translation alongside the document image by default if both are present, so that I can read the document in my native language. Jun 21, 2023
@blms blms self-assigned this Jun 22, 2023
blms added a commit that referenced this issue Jun 22, 2023
blms added a commit that referenced this issue Jul 20, 2023
Co-authored-by: Rebecca Sutton Koeser <rlskoeser@users.noreply.github.com>
blms added a commit that referenced this issue Aug 7, 2023
blms added a commit that referenced this issue Aug 8, 2023
…default

Set translation to appear by default; select translation based on user's language (#1400)
blms added a commit that referenced this issue Aug 8, 2023
for default/disabled panel behavior; see #1400
blms added a commit that referenced this issue Aug 9, 2023
…text

Include new default/disabled context variables in admin ITT viewer (#1400)
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Aug 9, 2023
@kseniaryzhova
Copy link
Author

@blms works well, thank you! Closing!

@blms blms removed the 🗜️ awaiting testing Implemented and ready to be tested label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant
Projects
None yet
Development

No branches or pull requests

2 participants