-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a front end desktop user, I would like to see a bigger version of the document image in order to read the document (especially when no transcription exists). #1413
Comments
@richmanrachel I wonder whether it may be sufficient to resize the browser window smaller in order to activate the mobile layout. This will give you about 900px width, as opposed to the default 640px of the desktop layout. Not huge, but a little bit extra width to work with. Here is a demonstration, first of the current desktop mode default and then of me resizing to activate the mobile layout: Screen.Recording.2023-07-12.at.4.19.28.PM.movIn comparison, here is what it might look like if we expand all images to nearly the full width by default. My concern here is the amount of scrolling and lack of an "overview"—it's not really possible to see the full length of the document when this is the case. Screen.Recording.2023-07-12.at.4.16.31.PM.movOf course, that still leaves the option to have this "full screen mode" enabled by clicking a button rather than the default. Maybe that's the best middle ground! But I welcome your thoughts (as well as @gissoo, @kseniaryzhova, @mrustow!). |
@blms I honestly think we should just have the full screen mode enabled by a button without any other solution. Because then that keeps the number of clicks you need to do low, but does give you the option to view it full screen if you need to. Honestly I've just been zooming in on the image in my browser, but I am very much a DIYer. |
@kseniaryzhova That's a great idea to use the browser zoom. I wonder if that would resolve the issue in general. Can you try that and see if it works for your needs, @richmanrachel? Of course, since that's not documented anywhere, users may not know to try it… |
@blms and @kseniaryzhova - the browser zoom isn't too bad (though I haven't tested it while trying to do a real transcription yet). I think a full screen mode might still be nice for certain research and teaching purposes, though. I'm happy to do it the way Ksenia recommended. |
Sounds good, let's go with the button click then. Thanks both! |
Add "enlarge image" button when only image visible (#1413)
@blms works as it should, although the person best suited to test is currently on maternity leave! Closing, thank you! |
Testing notes (QA)
On the QA public site, visit a document with only images.
Is your feature request related to a problem? Please describe.
When I am trying to skim documents for my research that don't yet have transcriptions, the box that the image is in is too narrow for me to read a whole line at a time. So I struggle with having to keep my place in the document while navigating back and forth dragging my mouse to read the document.
Describe the solution you'd like
An optional or default larger image box so that more of the document is visible in landscape at once.
Describe alternatives you've considered
Per our meeting 7/5/2023, we are open to different solutions:
Additional context
We're not sure if we'll want a similar full screen feature on the editor or not. Seems less useful, but not absurd to have.
The text was updated successfully, but these errors were encountered: