Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content admin, when viewing people-to-people relationships in person pages, I want reverse relationships to be visible, so that I don't inadvertently add a relationship twice. #1458

Closed
4 tasks done
blms opened this issue Sep 11, 2023 · 3 comments
Assignees
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant

Comments

@blms
Copy link
Contributor

blms commented Sep 11, 2023

testing notes (QA)

on the QA site admin:

  • If you select one of the entries in the list of Person-Person relationship types, you should be able to view and edit the converse relationship type name. All the ones from the spreadsheet should now be populated here.
  • Add some Person entries and some Person-Person relationships between them
  • After adding a single relationship between people, both people should have the relationship represented on their page
    • The first person should show the relationship you entered in the "Related People (input manually)" section, with the relationship type you selected
    • When you go to the other person's Person page, you should see the "converse" relationship type in the "Related People (automatically populated)"

dev notes

@blms blms self-assigned this Sep 11, 2023
@blms blms added 🆕 enhancement New feature or request performant Tasks for or taken on by Performant labels Sep 12, 2023
@blms
Copy link
Contributor Author

blms commented Sep 12, 2023

@kseniaryzhova A handful of questions that have come up in the process of implementing this:

  1. Should the reciprocal relations for “Maternal cousin” and “Paternal cousin” just be “Cousin”?

    • Example: if Jane is my maternal cousin because she’s my mother’s sister’s daughter, then the relationship is identical on both sides—I’m also her maternal cousin. But if Jane is my mother’s brother’s daughter, then while she’s still my maternal cousin, I’m actually her paternal cousin, because her father is who is related to me. In other words, if I add Jane in the DB as my maternal cousin, it’s ambiguous whether I’m Jane's maternal or paternal cousin.
  2. For the nephew and niece relations, is there a reason why we only have aunt and uncle relations as actual relationship types, and nephew/niece only appear as reciprocal relations?

  3. Is "Reverse name" and the following help text a good description for what we're talking about here? "Reciprocal" seems inaccurate (since it implies something done or given in return for something else, rather than a semantic complement)
    Screenshot 2023-09-12 at 4 12 31 PM

    • I'm using the term "semantic converse" here after some research on wikipedia 😆 is it clear what that means?
    • Does "symmetrical" convey enough information for what we mean when the relationship is the same in both directions?
  4. Do these header names make sense for separating the related people from the reverse read-only display? "People related to" seems confusing since it is semantically the same thing as "related people", but I'm struggling with the proper terminology here.
    Screenshot 2023-09-12 at 4 16 16 PM

    fwiw, here's what it looks like if I click that link to "Other person" and look at their related people section:
    Screenshot 2023-09-12 at 4 16 27 PM

@blms blms added the ❓ question Further information is requested label Sep 12, 2023
@blms
Copy link
Contributor Author

blms commented Sep 13, 2023

Answers from 9/13 meeting:

  1. Yes
  2. Should all appear individually, though "maternal niece/nephew" and "paternal niece/nephew" should be changed to "niece/nephew on sister's side" and "niece/nephew on brother's side"
  3. Change to "converse relationship," example is good, "Leave blank if the converse is identical"
  4. Change to "Related People (Input Manually)"
and
"Related People (Populated Automatically)"

@blms blms removed the ❓ question Further information is requested label Sep 13, 2023
blms added a commit that referenced this issue Sep 13, 2023
@blms blms added ❓ question Further information is requested and removed ❓ question Further information is requested labels Sep 13, 2023
blms added a commit that referenced this issue Sep 27, 2023
…-reverse

Person-Person: Add converse relationship types and display (#1458), add new "ambiguity" category (#1457)
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Oct 2, 2023
@kseniaryzhova
Copy link

@blms works as it should, thank you! Closing!

@blms blms removed the 🗜️ awaiting testing Implemented and ready to be tested label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant
Projects
None yet
Development

No branches or pull requests

2 participants