Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with shelfmark scoped search #1476

Closed
3 tasks done
blms opened this issue Oct 18, 2023 · 1 comment
Closed
3 tasks done

Issues with shelfmark scoped search #1476

blms opened this issue Oct 18, 2023 · 1 comment
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@blms
Copy link
Contributor

blms commented Oct 18, 2023

testing notes

On the QA site:

  • Searching for most shelfmarks using the syntax shelfmark:"T-S 12.302", shelfmark:"AIU II.A.73", etc should bring up the correct results
  • There should not be a bunch of irrelevant results containing the word "type" highlighted (this is what was happening before—and what this issue was intended to fix)
  • Both on the public site and admin, it should work roughly the same way (though the admin search is not ordered by relevance)

  • Shelfmark scoped search brings up irrelevant results after the relevant ones. This was happening before the solr 9 upgrade, but since then, it seems to highlight the word "type" in each additional result. More here: upgrade to Solr 9.2 #1359 (comment)
  • Searching for shelfmark:"T-S 12.30", the relevance score seems like it may be wrong, since all the partial matches like "T-S 12.304" come up before "T-S 12.30 + JRL SERIES B 2367". Maybe it's a problem with joins. (confirmed, it is a problem with joins, unrelated.)
  • Does not work at all in admin search
@blms blms added the 🐛 bug Something isn't working label Oct 18, 2023
@richmanrachel richmanrachel added this to the Search milestone Feb 6, 2024
blms added a commit that referenced this issue Feb 9, 2024
@blms blms self-assigned this Feb 9, 2024
blms added a commit that referenced this issue Feb 12, 2024
Allow deprecated edismax nested search for shelfmarks (#1476)
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Feb 23, 2024
@kseniaryzhova
Copy link

@blms works as it should, closing, thanks!

@blms blms removed the 🗜️ awaiting testing Implemented and ready to be tested label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants