Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content editor, I want clearer help text for the name field of the person page so I know how best to present people's names on their pages #1480

Closed
3 tasks done
kseniaryzhova opened this issue Oct 19, 2023 · 3 comments
Assignees
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant
Milestone

Comments

@kseniaryzhova
Copy link

kseniaryzhova commented Oct 19, 2023

testing notes (QA)

On the QA admin site:

  • When adding or modifying a Person record, the help text for the Language field should include the text "Refers to the language in which a name is written, not the linguistic origin of the name. Ex: “Nahray b. Nissim” should be marked as English."
  • The help text for the Name field should say "Please add common forms of the name in both English and other languages in which it appears in documents."
  • These should also appear when adding or modifying a Place record

Describe the solution you'd like
For the language section of the name field in the people module: Language refers to the keyboard. Ex. “Mūsa” and “Moshe” are English, but משה is Hebrew and מוסה is Judaeo-Arabic
For the name section of the name field in the people module: Please add common forms of the person’s name in both English and the other languages the person is referred to in documents”

Additional context
image

@kseniaryzhova kseniaryzhova added 🆕 enhancement New feature or request performant Tasks for or taken on by Performant labels Oct 19, 2023
@kseniaryzhova kseniaryzhova changed the title Please update and add help text for people module name field As a content editor, I want clearer help text for the name field of the person page so I know how best to present people's names on their pages Oct 19, 2023
@kseniaryzhova
Copy link
Author

@blms Help text we decided on: “Refers to the language in which a name is written, not the linguistic origin of the name. Ex: “Nahray b. Nissim” should be marked as English."

@richmanrachel richmanrachel added this to the People milestone Feb 6, 2024
@blms blms self-assigned this Mar 6, 2024
blms added a commit that referenced this issue Mar 6, 2024
blms added a commit that referenced this issue Mar 6, 2024
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Mar 11, 2024
@kseniaryzhova
Copy link
Author

@blms maybe the help text for places should say "Fusṭāṭ" should be marked as English? Instead of Nahray, since it's confusing.

blms added a commit that referenced this issue Mar 11, 2024
@kseniaryzhova
Copy link
Author

@blms perfect, works great! Thank you, closing!

@blms blms removed the 🗜️ awaiting testing Implemented and ready to be tested label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant
Projects
None yet
Development

No branches or pull requests

3 participants