Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content admin, I want to drop down a pin on a map and then be able to move the pin around so that I can manually adjust the coordinates of a place before saving the location. #1494

Closed
7 tasks done
kseniaryzhova opened this issue Nov 1, 2023 · 3 comments
Assignees
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant
Milestone

Comments

@kseniaryzhova
Copy link

kseniaryzhova commented Nov 1, 2023

testing notes (QA)

On the QA site admin:

  • Edit an existing Place record. If it has coordinates saved, it should show a map with a pin on that location
    • You should be able to zoom and pan the map (scroll to zoom, click and drag to pan)
    • Moving the pin should change the coordinates
    • Changing the coordinates should move the pin
  • Create a new Place. You should see a map centered on the Ben Ezra Synagogue in Fustat, but the coordinates fields should be blank
    • Moving the pin should enter coordinates into the fields
    • Entering coordinates should move the pin

Describe the solution you'd like
A la Google Maps, we want to be able to click on a location on a map and then move the pin around to adjust the coordinates before finalizing.

@kseniaryzhova kseniaryzhova added 🆕 enhancement New feature or request performant Tasks for or taken on by Performant labels Nov 1, 2023
@richmanrachel richmanrachel modified the milestones: Places, Documents Feb 6, 2024
@blms blms self-assigned this Feb 16, 2024
@blms blms changed the title As a content admin, I want to drop down a pin on the places map and then be able to move the pin around so that I can manually adjust the coordinates of a place before saving the location. As a content admin, I want to drop down a pin on a map and then be able to move the pin around so that I can manually adjust the coordinates of a place before saving the location. Feb 16, 2024
@blms blms modified the milestones: Documents, Places Feb 27, 2024
blms added a commit that referenced this issue Feb 27, 2024
Allow user to use a map and pin to set place coordinates (#1494)
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Mar 4, 2024
@kseniaryzhova
Copy link
Author

@blms I do not see a map at all, not in existing place locations, not in new ones.
image

@kseniaryzhova kseniaryzhova added ⚠️ tested needs attention Has been through acceptance testing and needs additional work and removed 🗜️ awaiting testing Implemented and ready to be tested labels Mar 4, 2024
@kseniaryzhova
Copy link
Author

@blms so it was briefly working and I could see the map and interact with the pin and zoom in and all that and then it disappeared on me. All the place entries I opened after a certain point had no map at all, even after a hard refresh.

@kseniaryzhova
Copy link
Author

@blms works really well, thank you! Closing!

@blms blms removed the ⚠️ tested needs attention Has been through acceptance testing and needs additional work label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant
Projects
None yet
Development

No branches or pull requests

3 participants