Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content editor, I would like to see Historic Shelfmark on the Document edit page, to ensure that my work is correct when working with old scholarship. #271

Closed
1 task done
richmanrachel opened this issue Aug 18, 2021 · 6 comments
Assignees
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant
Milestone

Comments

@richmanrachel
Copy link

richmanrachel commented Aug 18, 2021

Testing notes (QA)

On the QA site admin:

  • Edit a document that has historical shelfmarks. They should show up in the top section alongside PGPID and old PGPID.

As followup to #241, we would like a read-only Historic Shelfmark field to be present on Document Detail view adjacent to the other PGPID/Old PGPID information (see image below).

Is your feature request related to a problem? Please describe.
Given that most of our researchers will only be working in Document View, it's necessary to see the historic shelfmark in this view. Without it, it could lead to confusion, particularly for less experienced researchers doing data entry from older source material.

image

@rlskoeser rlskoeser changed the title As a content editor, I would like to see Historic Shelfmark on Document Detail View, to ensure that my work is correct when working with old scholarship. As a content editor, I would like to see Historic Shelfmark on the Document edit page, to ensure that my work is correct when working with old scholarship. May 2, 2022
@kseniaryzhova
Copy link

@blms Could we do this please, esnpecially since we just ingested a ton of historic shelfmarks. How long would it take?

@blms
Copy link
Contributor

blms commented Jan 30, 2024

Definitely @kseniaryzhova, probably a 3 hour or less task. I'll put it on my list!

@blms blms self-assigned this Jan 30, 2024
@kseniaryzhova kseniaryzhova added the performant Tasks for or taken on by Performant label Jan 31, 2024
@kseniaryzhova
Copy link

@blms Great, definitely lower priority," to do when there's a lull in the other high priority work" kind of thing.

@kseniaryzhova
Copy link

#1469 is the same, closing this one!

@blms
Copy link
Contributor

blms commented Feb 8, 2024

@kseniaryzhova Reopening as this refers to the admin site, not the public site!

@blms blms reopened this Feb 8, 2024
blms added a commit that referenced this issue Mar 6, 2024
Show historical shelfmarks on document detail page (#271)
@blms blms added 🆕 enhancement New feature or request 🗜️ awaiting testing Implemented and ready to be tested labels Mar 11, 2024
@kseniaryzhova
Copy link

@blms perfect! Thanks, closing!

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant
Projects
None yet
Development

No branches or pull requests

4 participants