-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
off-screen menu shows up when resizing browser window #411
Labels
🐛 bug
Something isn't working
Comments
Also appears on mobile, e.g. when searching or navigating between search and document details. |
blms
added a commit
that referenced
this issue
Mar 4, 2022
blms
added a commit
that referenced
this issue
Mar 4, 2022
Fix issue with mobile menus appearing from off-screen (#411)
blms
added a commit
that referenced
this issue
Mar 4, 2022
blms
added a commit
that referenced
this issue
Mar 4, 2022
Fix percy-specific CSS for mobile menus (#411)
tested with browser resizing, browser simulating mobile, and used Firefox on my phone — no sign of the off screen menu when it isn't supposed to be there! (and still works as expected when I want to use the menu) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
testing notes
Confirm the mobile menus do not appear from offscreen during any of the following actions:
When I resize the window, at certain widths the mobile menus show up and then disappear again at the sides of the page.
I think this is a bug but not a very high priority one, since I don't think it's too likely to happen with real-world behaviors.
Here's a video capture of the behavior:
Screen.Recording.2021-12-13.at.4.18.44.PM.mov
The text was updated successfully, but these errors were encountered: