Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content editor, I want scholarship record summary information included in documents metadata so I can quickly see who has published on the document without switching context. #475

Closed
6 tasks done
mrustow opened this issue Dec 27, 2021 · 8 comments
Assignees

Comments

@mrustow
Copy link

mrustow commented Dec 27, 2021

testing notes

  • the documents CSV export should now include a scholarship_records field
  • should appear after the description
  • should include the short display version of the footnote record for all footnotes associated with that document
  • should handle multiple footnotes
  • should be empty if there are no footnotes
  • download should still be reasonably quick (expect it to be similar to before)

As a content admin, I would like footnotes included in .csv exports from the admin interface so that I can see who has published the document just by looking at the subset of docs I've exported, without referring back to the admin interface and without having to input the information manually.

Admittedly, the resulting .csv will be unwieldy, but it's already unwieldy and one can easily jettison columns, whereas it's difficult to add information that isn't there.

@rlskoeser
Copy link
Contributor

@mrustow what's the minimum version of this that would be useful? Could we give you just the names of all the editors? Names of any authors of scholarship records? Or do you need to know who/what (edition/translation/transcription) and where something is published for it to be useful to you?

I'm concerned about how much adding this information might slow down the export, but we can check while we're working on the data exports this week. And if we switch to automated data exports for the full set, and this doesn't impact smaller data exports too much, then performance may not be as much of a concern.

@mrustow
Copy link
Author

mrustow commented Oct 10, 2022

It would be hugely useful if we had info at the level that we get in the drop-down menu when adding a transcription, so, e.g., "Khan, Arabic Legal and Administrative Documents" or "Goitein, unpublished transcriptions, T-S 8." Minimal is better than maximal!

@rlskoeser
Copy link
Contributor

@mrustow ok, thanks for elaborating. And just to confirm, you prefer to have all this with the documents metadata, not in a secondary file?

@mrustow
Copy link
Author

mrustow commented Oct 10, 2022

right. most intuitive for me would be in the column to the right of the description, because that's where it was in the old days.

@rlskoeser
Copy link
Contributor

@mrustow great, thank you — that makes sense.

@kseniaryzhova
Copy link

@rlskoeser I think we can close (or merge?), given we have a separate csv for footnotes that has all of this information listed.

@rlskoeser
Copy link
Contributor

@kseniaryzhova thank you for reminding me about this! I meant to take a look and see how easily we can add to the export and how much it impacts the time. I know it would be easier for Marina if we have that information included in the main documents spreadsheet.

@rlskoeser rlskoeser changed the title Include footnotes in .csv exports As a content editor, I want scholarship record summary information included in documents metadata so I can quickly see who has published on the document without switching context. Nov 17, 2022
@rlskoeser rlskoeser reopened this Nov 17, 2022
@rlskoeser rlskoeser self-assigned this Nov 17, 2022
rlskoeser added a commit that referenced this issue Nov 18, 2022
* Add scholarhip records display to documents metadata #475

* Improve prefetching for source/footnote metadata exports

* Update metadata export tests

* Use set comprehension syntax as suggested by @quadrismegistus
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Nov 18, 2022
@kseniaryzhova
Copy link

@rlskoeser works for me! Thank you, closing!

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants