Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content editor, I want to add SVG images to content pages so that I can include data visualizations and other scalable images. #590

Closed
1 task done
rlskoeser opened this issue Feb 8, 2022 · 2 comments
Assignees
Milestone

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Feb 8, 2022

testing notes (qa)

  • In the QA Wagtail interface, edit a content page and add an "SVG" block in the body (instead of "image" or "paragraph"). Confirm that you can upload an SVG image file, add a caption, etc.

dev notes

Hopefully we can adapt the svg image block directly from mep-django codebase

@blms blms self-assigned this Mar 3, 2022
blms added a commit that referenced this issue Mar 3, 2022
rlskoeser added a commit that referenced this issue Mar 8, 2022
@blms
Copy link
Contributor

blms commented Mar 8, 2022

Just noticed from the merge Percy screenshots that it looks like the max-width for landscape images was accidentally changed, so I'll have to make sure to fix that!

@rlskoeser rlskoeser added this to the v4.3 milestone Mar 9, 2022
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Mar 9, 2022
@richmanrachel
Copy link

I don't know how to test the screen reader, but it all seems to be working! (I added some trees to the end of the credits page if you want to check)

@richmanrachel richmanrachel removed the 🗜️ awaiting testing Implemented and ready to be tested label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants