Refactor all JS to Stimulus

[blms]

dev notes

Stimulus was first used for the relevance sort in #550, the following should also be refactored to use Stimulus:

• search.js (all functionality should be moved over to controllers/search_controller.js)
• submenu.js
• theme_toggle.js
• openseadragon.js (see Turbo integration (#635) and automatic search (#638) #684)

[rlskoeser]

@blms regarding your note about search.js "extending" the search controller — we should just port the existing logic over to the search controller, right?

[blms]

@rlskoeser exactly!

[rlskoeser]

@blms what about openseadragon init?

[blms]

@rlskoeser Ah, I didn't think to include it since it's just injecting OSD vendor code into the HTML, but it probably should be included, I'll add it to the list!

[rlskoeser]

We may want to split this out into separate subtasks, but can wait and see how it goes; am wondering if the seadragon should be more of a progressive enhancement. I was looking at the site on my phone and wasn't seeing images on detail pages — which we should check on — but made me wonder if you really want deep zoom by default on mobile.

[blms]

@rlskoeser Good call, and I see the mobile issue—it occurs on pages where there are images but no transcription. I'll track it as a bug!

[rlskoeser]

@blms great — thanks for documenting, we should get that resolved

[rlskoeser]

confirmed in qa, but noticed we're still including a main.js bundle that appears to be empty — let's remove that one before we close this

[rlskoeser]

confirmed main.js removed in qa