Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the site header for the Hebrew site #696

Closed
3 tasks done
gissoo opened this issue Mar 7, 2022 · 6 comments
Closed
3 tasks done

Implement the site header for the Hebrew site #696

gissoo opened this issue Mar 7, 2022 · 6 comments
Assignees

Comments

@gissoo
Copy link
Contributor

gissoo commented Mar 7, 2022

testing notes (qa)

On the QA site, visit the home page and switch to Hebrew mode, then check the header:

  • Desktop light/dark
  • Mobile light/dark
  • On another page (not home page)

And confirm it looks and functions as expected.


Please refer to this comment on the design issue #631

the header files have been uploaded to github

@blms
Copy link
Contributor

blms commented Mar 11, 2022

Possible side effect from the work on this issue: when you switch between light and dark on mobile, the menu items' text color does not update, so they appear invisible.

@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Mar 11, 2022
blms added a commit that referenced this issue Mar 11, 2022
Fix light/dark mode switch for RTL header (#696)
@richmanrachel
Copy link

@gissoo - this worked perfectly for me on Chrome on desktop!

@gissoo
Copy link
Contributor Author

gissoo commented Apr 4, 2022

@richmanrachel thanks for testing!

@blms There are a couple of issues on mobile and safari desktop and mobile, they're not terrible but wanted to make sure they are documented here:

  • on mobile chrome, safari, and FF the language toggles don't show up, not sure if it's part of this issue or is intentional
  • on mobile, on Safari, the logo's side (its bottom left) seems a bit off

Screen Shot 2022-04-04 at 12 31 16 PM

  • on desktop on safari the bottom part below "project" is a bit off

Screen Shot 2022-04-04 at 12 33 08 PM

  • on mobile on safari the header image seems to suddenly disappear rather than a smooth transition – I don't know if it's also an issue on the dark mode, but it's definitely an issue on light mode.

Screen Shot 2022-04-04 at 12 35 14 PM

@gissoo gissoo removed the 🗜️ awaiting testing Implemented and ready to be tested label Apr 11, 2022
@blms blms added the ⚠️ tested needs attention Has been through acceptance testing and needs additional work label Apr 11, 2022
blms added a commit that referenced this issue Apr 12, 2022
blms added a commit that referenced this issue Apr 12, 2022
blms added a commit that referenced this issue Apr 12, 2022
blms added a commit that referenced this issue Apr 12, 2022
@blms blms removed the ⚠️ tested needs attention Has been through acceptance testing and needs additional work label Apr 12, 2022
@blms
Copy link
Contributor

blms commented Apr 13, 2022

on mobile chrome, safari, and FF the language toggles don't show up, not sure if it's part of this issue or is intentional

That is intentional until we have a design for it, as it breaks layout on mobile!

@gissoo
Copy link
Contributor Author

gissoo commented Apr 14, 2022

@blms, thank you! These look much better now! The only one that is very noticeably wrong is this one, desktop Firefox, if you can't replicate it then ignore me.

Screen Shot 2022-04-14 at 1 48 33 PM

@blms
Copy link
Contributor

blms commented Apr 14, 2022

@gissoo, I can't replicate, here's what it looks like for me on FF. Maybe a cached version on your end?

Screen Shot 2022-04-14 at 1 57 35 PM

Should we go ahead and close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants