-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the site header for the Hebrew site #696
Comments
Possible side effect from the work on this issue: when you switch between light and dark on mobile, the menu items' text color does not update, so they appear invisible. |
Fix light/dark mode switch for RTL header (#696)
@gissoo - this worked perfectly for me on Chrome on desktop! |
@richmanrachel thanks for testing! @blms There are a couple of issues on mobile and safari desktop and mobile, they're not terrible but wanted to make sure they are documented here:
|
That is intentional until we have a design for it, as it breaks layout on mobile! |
@blms, thank you! These look much better now! The only one that is very noticeably wrong is this one, desktop Firefox, if you can't replicate it then ignore me. |
@gissoo, I can't replicate, here's what it looks like for me on FF. Maybe a cached version on your end? Should we go ahead and close this? |
testing notes (qa)
On the QA site, visit the home page and switch to Hebrew mode, then check the header:
And confirm it looks and functions as expected.
Please refer to this comment on the design issue #631
the header files have been uploaded to github
The text was updated successfully, but these errors were encountered: