Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a front end user, I want to be able to easily select shelfmarks for copy and paste on the document detail page, so that I can enter that information elsewhere. #705

Closed
5 tasks done
blms opened this issue Mar 8, 2022 · 3 comments
Assignees
Milestone

Comments

@blms
Copy link
Contributor

blms commented Mar 8, 2022

review notes

  • On a document detail page, click on the shelfmark(s) in the title header, and confirm all shelfmarks are automatically selected
  • Confirm that is the desired functionality, rather than selecting individual shelfmarks

dev notes

  • try css user-select
  • fix edit container in the way for logged in users
  • stimulus controller for copy (disabled for now)
@blms blms self-assigned this Mar 8, 2022
blms added a commit that referenced this issue Mar 8, 2022
blms added a commit that referenced this issue Mar 8, 2022
blms added a commit that referenced this issue Mar 8, 2022
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Mar 9, 2022
@richmanrachel
Copy link

@blms - I love this! I'll see if I have a moment to ask Marina about it at the end of our meeting with Gissoo, but I think it's nice that the joins come together (since I want the full document, not just individual fragments to be recorded in my notes).

@rlskoeser
Copy link
Contributor

@richmanrachel I wondered about that! I had assumed individual shelfmarks but when I saw Ben's implementation recognized it had never been made explicit.

@rlskoeser rlskoeser added this to the v4.3 milestone Mar 9, 2022
@richmanrachel
Copy link

@blms - Marina loves the single click for the joins! "It's like getting a hug from a developer!" :) I think that merits closing, haha

@richmanrachel richmanrachel removed the 🗜️ awaiting testing Implemented and ready to be tested label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants