Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a frontend user, I want to see primary and secondary languages when they've been assigned so that I have access to the known information about the document. #715

Closed
7 tasks done
richmanrachel opened this issue Mar 10, 2022 · 3 comments
Assignees
Milestone

Comments

@richmanrachel
Copy link

richmanrachel commented Mar 10, 2022

testing notes

Review public document details pages on test site for documents with and without languages.

  • documents without languages set should not display any language sections
  • document should display one or more primary languages when set
    • single language examples: PGPIDs 468, 495, 473
    • multiple language examples: PGPIDS 503, 462
  • documents should display one or more secondary languages when set
    • single secondary language examples: PGPIDs 475, 501, 712
    • multiple secondary language examples: PGPIDs 1036, 1442

Note that I'm not currently displaying the contents of the language notes anywhere — I couldn't figure out how to easily fit it into the display; maybe we can fold this into the other document detail revisions that Gissoo needs to do.

Is your feature request related to a problem? Please describe.
We need the front and backend information to be more similar, as we're asking RAs to avoid repeating information in the description that has a dedicated field.

Describe the solution you'd like
Language should show up as another field (perhaps below editor information and above the description).

@rlskoeser rlskoeser self-assigned this Mar 11, 2022
@rlskoeser rlskoeser changed the title As a frontend user, I want to see primary and secondary languages when they've been assigned in order to make frontend and admin site more parallel. As a frontend user, I want to see primary and secondary languages when they've been assigned so that I have access to the known information about the document. Mar 11, 2022
rlskoeser added a commit that referenced this issue Mar 11, 2022
- also move secondary metadata below description

ref #715
@rlskoeser rlskoeser added this to the v4.3 milestone Mar 11, 2022
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Mar 11, 2022
@richmanrachel
Copy link
Author

image

Is it just the font, or is there actually more space between Hebrew and Judaeo-Arabic than Primary Languages and Hebrew?

@richmanrachel
Copy link
Author

@rlskoeser - everything works, but I think we still need to improve design to make the internal headers clearer and to handle language notes (as you mentioned above).

I don't see a current issue of @gissoo's to track these details. Should I close and make one?

@rlskoeser
Copy link
Contributor

@richmanrachel I agree, the problem with the internal headers is more and more obvious to me — I wanted to work within the existing styles for this quick change, but agree we need to address. It makes sense to me to add an issue for that. We may need an epic to track all the revisions needed for the document detail page, but creating the specific issue for this is fine for now.

@richmanrachel richmanrachel removed the 🗜️ awaiting testing Implemented and ready to be tested label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants