Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a frontend user, I want to easily find other documents on the same fragment in order to better interpret the images and gain context. #716

Closed
4 tasks done
richmanrachel opened this issue Mar 10, 2022 · 1 comment
Assignees
Milestone

Comments

@richmanrachel
Copy link

richmanrachel commented Mar 10, 2022

testing notes

On the test site, documents that share the same fragment should now be linked to each other  — links should display under the description & secondary metadata, and should only link to public documents (not suppressed).

Note, I put this before transcription+image because I thought if it came after people are more likely to miss it. LMK if you want it moved when you test.

Here are some sample documents & cases to test, but you may want to check others:

  • section should not display if no other public documents are on the same fragment
  • should not link to suppressed document on the same fragment (test with PGPID 2661 and PGPID 35058)
  • single fragment, multiple documents: PGPID 494
  • multiple fragments, multiple documents: PGPIDs 31147; 31149; 494, 6178

Is your feature request related to a problem? Please describe.
The admin site now makes it easy to click on related fragments/documents, but the frontend solution is to search the shelfmark and open both/multiple entries separately. It would also be easy to not realize part of the fragment has already been described if you've found the document through a different search term.

Describe the solution you'd like
Below the image/transcription, there should be live links to other PGPID document detail pages for the same/related fragment(s).

@rlskoeser rlskoeser self-assigned this Mar 11, 2022
rlskoeser added a commit that referenced this issue Mar 11, 2022
ref #716

- method to find other documents on same fragments
- display other documents on document detail page
- adjust canonical/alternate links in header
rlskoeser added a commit that referenced this issue Mar 11, 2022
ref #716

- method to find other documents on same fragments
- display other documents on document detail page
- adjust canonical/alternate links in header
@rlskoeser rlskoeser added this to the v4.3 milestone Mar 11, 2022
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Mar 11, 2022
@richmanrachel
Copy link
Author

@rlskoeser - this is wonderful! Closing :)

@richmanrachel richmanrachel removed the 🗜️ awaiting testing Implemented and ready to be tested label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants