Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the placement of the burger menu on mobile so that it's on the opposite side from the logotype #749

Closed
2 tasks done
gissoo opened this issue Apr 4, 2022 · 1 comment
Closed
2 tasks done

Revise the placement of the burger menu on mobile so that it's on the opposite side from the logotype #749

gissoo opened this issue Apr 4, 2022 · 1 comment
Assignees
@blms
Labels
chore

Comments

@gissoo
Copy link
Contributor

gissoo commented Apr 4, 2022 •
edited

Testing notes (qa)

  • Open the QA site on a mobile device and confirm that the burger menu is in the correct position
  • Change the language to Hebrew and confirm the burger menu is in the correct position for RTL

here is the revised placement of the burger menu on mobile
@gissoo gissoo added the chore label Apr 4, 2022
blms added a commit that referenced this issue Apr 21, 2022
@blms
Revise placement of "burger" menu (#749)
4db9291
@blms blms mentioned this issue Apr 21, 2022
Merged
blms added a commit that referenced this issue Apr 21, 2022
@blms
Merge pull request #792 from Princeton-CDH/feature/burger-menu
e8d7c22 
Revise placement of "burger" menu (#749)
@gissoo
Copy link
Contributor Author

gissoo commented Apr 22, 2022

@blms this works perfectly! I had to do it in the browser since I can't change language on mobile(?)

@gissoo gissoo closed this as completed Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blms blms

Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blms @gissoo