Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement designs for the RTL search form for light and dark mode for desktop and mobile #753

Closed
1 task done
gissoo opened this issue Apr 4, 2022 · 1 comment
Closed
1 task done

Implement designs for the RTL search form for light and dark mode for desktop and mobile #753

gissoo opened this issue Apr 4, 2022 · 1 comment
Assignees
@blms @gissoo

Comments

@gissoo
Copy link
Contributor

gissoo commented Apr 4, 2022 •
edited

testing notes (qa)

  • On the QA site, switch to Hebrew and confirm that the search form looks correct in light mode, dark mode, mobile, and desktop

The translations and the rest of the search results page are out of scope for this issue.

Here are the designs on Figma
@gissoo gissoo changed the title Implement the designs for the RTL search form for light and dark mode for desktop and mobile Implement designs for the RTL search form for light and dark mode for desktop and mobile Apr 5, 2022
@blms blms mentioned this issue Apr 11, 2022
Closed
2 tasks
blms added a commit that referenced this issue Apr 28, 2022
@blms
RTL revisions for search form (#753)
9d72a85
@blms blms mentioned this issue Apr 28, 2022
Merged
blms added a commit that referenced this issue Apr 28, 2022
@blms
Merge pull request #821 from Princeton-CDH/feature/753-rtl-searchform
a7aa04a 
RTL revisions for search form (#753)
blms added a commit that referenced this issue Apr 28, 2022
@blms
Adjust margins for submit button on mobile (#753)
9740bdf
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Apr 29, 2022
@gissoo
Copy link
Contributor Author

gissoo commented May 2, 2022

@blms these look correct!! Thank you!

@blms blms closed this as completed May 2, 2022
@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blms blms

@gissoo gissoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rlskoeser @blms @gissoo