Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content editor, I want to add block-level transcription to documents with images so that I can make existing transcription content available in the site. #757

Closed
15 tasks done
rlskoeser opened this issue Apr 4, 2022 · 13 comments
Assignees

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Apr 4, 2022

testing notes 2 (qa)

Using the new transcription page:

  • Confirm images are loading
  • Confirm you can save/edit/delete transcriptions on PGPID 11248

notes for testing

Go to the test site and make sure you are logged in as a content editor. Find a document with images associated and go to the public document details view. If you navigate from the public search, you will need to reload the page because the transcription javascript doesn't play nicely with turbo yet.

At the right of the image/transcription view you should see a "transcribe" button, which will put you into transcription/annotation mode.

Please try creating, editing, and deleting some test annotations. Here are some things you may want to try:

  • draw a rectangle on the image then cancel
  • draw a rectangle on the image, add any text, and save
  • reload the page and re-enable transcription mode — confirm that the text you added was saved and persistent
  • click the text block or the rectangle on the image to edit
  • change the text and save
  • change the image selection zone and save
  • delete a saved annotation, then reload to confirm it was removed from storage

We're aware of an issue where editing the zone on the image and then updating and saving the text reverts the zone back to what it was before you changed it. You will likely find others!

dev notes

@rlskoeser rlskoeser self-assigned this Apr 15, 2022
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label May 12, 2022
@richmanrachel
Copy link

@rlskoeser - another little error, because I just reloaded the test admin page I was on and saw that "transcribe" was an option: I clicked it and it acted like the "save" button, saving changes and sending me back to the document list view.

Then I moved to the public test site, and "transcribe" just zooms me in on the image. I can't seem to draw boxes or anything....

@rlskoeser
Copy link
Contributor Author

ah, yeah — forgot to warn you that the transcribe functionality is partially present in the admin view but I don't expect it to be operational right now.

You have to hold shift before you click on the image — sometimes the first time I try it moves the image and the next time it lets me select a zone.

@richmanrachel
Copy link

Update: drawing boxes was not possible for me on Chrome Version 101.0.4951.54 (Official Build) (arm64)

I was able to draw boxes (and delete them via the esc button) on Safari Version 15.1 (17612.2.9.1.20)

But even on Safari, I couldn't figure out how to add/edit text. There were also some weird issues with the boxes as I was zooming/moving around the screen (here you can see how half of it disappeared):
image

@richmanrachel
Copy link

[That's also really strange that my screenshot inverted....]

@rlskoeser - Am I supposed to see any menu items to help guide me where to transcribe? I don't see a text box, and when I started typing to see if it filled in the existing box, it just moved me around the screen.

@richmanrachel
Copy link

richmanrachel commented May 12, 2022

With some troubleshooting through private Slack messages, I figured out my browser window at first wasn't wide enough to show the transcription options [and thus Chrome is working when I make it wide enough].

For whatever reason, @rlskoeser's test on PGPID 2806 is working and saving, but Rachel's on 11248 doesn't save. Perhaps it's because 2806 has an existing transcription and 11248 doesn't?

I can't get the boxes to resave in different configurations.

@richmanrachel richmanrachel added ⚠️ tested needs attention Has been through acceptance testing and needs additional work and removed 🗜️ awaiting testing Implemented and ready to be tested labels May 12, 2022
@rlskoeser
Copy link
Contributor Author

A few more notes from discussion with RR on Slack yesterday:

  • transcription editing should be on a separate page, not embedded on document details or document admin edit form (although it should be linked and accessible from both for those who have permission); this is better for implementation anyway, since it simplifies permissions checks (happen at the view-level) and turbo integration (transcription page can break out of the turbo frame)
  • transcription interface needs to be much more responsive than the current prototype is; e.g., RR wants to use the browser at half-width on a laptop screen so she can refer to other sources as she works on the transcription. Gissoo's designs for image + transcription should help significantly here.
  • content editor permissions are appropriate access for allowing transcription (probably key on permission to edit documents)

@rlskoeser
Copy link
Contributor Author

I tested making an annotation on a document that has a CUDL image and it worked fine; I have a suspicion the problem may be the image ids we have for JTS/Figgy content, maybe we're not urlencoding the urls properly. I think we'll be adjusting what ids we use to attach our annotations, but this is good to be aware of and make sure we test on both sets of content.

@mrustow
Copy link

mrustow commented May 13, 2022

I tested everything with a CUDL image (PGPID 18622) on Vivaldi and it all worked perfectly. My only complaint is that the image box is small; I couldn't both read as up-close as needed and see the entire line. I have some suggestions there but I'll hold off until design implementation.

@richmanrachel
Copy link

@rlskoeser - any updates on this one? It's been tagged with "tested needs attention" since May.

@rlskoeser
Copy link
Contributor Author

@richmanrachel it's stuck waiting on the new image+transcription viewer, but that work is almost done and Ben has started the work on the new transcribe page that integrates that layout.

@richmanrachel
Copy link

@rlskoeser - the images aren't really loading on the transcribe page (I tried this PGPID and 2 others with CUDL and ENA). They flash on and then disappear :(

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Jul 25, 2022
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Aug 3, 2022
@richmanrachel
Copy link

@blms and @rlskoeser - for some reason the transcription edit button has disappeared... I have the top admin edit button, but not the transcription one

@richmanrachel richmanrachel removed the 🗜️ awaiting testing Implemented and ready to be tested label Aug 3, 2022
@richmanrachel
Copy link

It works! Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants