Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design to view all images, or transcriptions, or translations together #783

Closed
gissoo opened this issue Apr 20, 2022 · 13 comments
Closed

Design to view all images, or transcriptions, or translations together #783

gissoo opened this issue Apr 20, 2022 · 13 comments
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Apr 20, 2022

This issue includes:

  1. the layout of content when viewing all of one record type (all images, vs. all transcriptions, vs. all translations) on desktop and mobile

Please review issues #782 and #784 before reviewing this issue.

@gissoo gissoo added the 🗺️ design Tracks design work in an external app label Apr 28, 2022
@gissoo gissoo self-assigned this Apr 28, 2022
@gissoo gissoo added the 💬 awaiting review Ready for comments and questions label May 2, 2022
@gissoo
Copy link
Contributor Author

gissoo commented May 2, 2022

@rlskoeser @mrustow @richmanrachel Please take a look at the screenshots below and let me know:

  1. Is it OK with you that we do not paginate this view? (since the whole point of this view is to look at all records at the same time)
  2. Is it OK with you if we display "x total images/transcriptions/translations" on top?
  3. Do we need to repeat "transcription"? Can we put that as a heading once on top?

Screen Shot 2022-05-02 at 6.35.32 PM.png

Screen Shot 2022-05-02 at 6.35.58 PM.png

@mrustow
Copy link

mrustow commented May 2, 2022

I need more context. Can we discuss IRT?

@richmanrachel
Copy link

Is it OK with you that we do not paginate this view? (since the whole point of this view is to look at all records at the same time)

  • Yes, per our conversation at the meeting this morning.

Is it OK with you if we display "x total images/transcriptions/translations" on top?

  • I don't think we need to have that/it's confusing if you're not seeing all 3 editions at the same time.

Do we need to repeat "transcription"? Can we put that as a heading once on top?

  • No need to repeat, a header is fine.

@rlskoeser
Copy link
Contributor

  1. I love the non-paginated view! Great for reading / viewing one thing in sequence from start to finish.
  2. Let's not display, seems unnecessary and potentially confusing — it seems particularly ambiguous for transcription/translation, how do we count things?
  3. Please let's not repeat.

@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label May 11, 2022
@gissoo gissoo added the 💬 awaiting review Ready for comments and questions label May 25, 2022
@gissoo
Copy link
Contributor Author

gissoo commented May 26, 2022

@rlskoeser I have covered 2 different cases for this issue:

  1. document with many images with every recto and verso and some region info

  2. this document and this document with one recto and verso, with region info, and transcription for one image/side only

  • when available shelfmark and side information appear together and region info appears below the two. Please take a look at the guides I've included on the first document mock up on desktop and mobile to see the spacing specs
  • on desktop please use 20px in bold for shelfmark, side, and region info, and on mobile 18px in bold.

Please let me know if you notice any problems.

@rlskoeser
Copy link
Contributor

Want to make sure I'm understanding what these designs indicate: we should display the image label (shelfmark + side) on the transcription and translation panels but only when they are viewed by themselves? Or only when the images are not showing?

That seems ok; some redundancy in the page, and we'll have to figure out how to handle transitions/spacing when showing and hiding that label, but make sense to provide the context.

fwiw, this will be messy with current transcription content, which sometimes duplicate this content. But that should be temporary, so I'm ok with it.

What are the implications for transcription + translation display?

@richmanrachel
Copy link

@gissoo - can we use a different heading style for the shelfmark? It's a little confusing to have "recto" on the same line/in the same font size, but then have "verso" on its own line:
image

@richmanrachel
Copy link

@gissoo - it might also help if Marina or I give you a more realistic example with the proper labels, as I think I'm also being thrown by the usage in the example. I'm happy to help right after today's meeting or next week.

@gissoo
Copy link
Contributor Author

gissoo commented Jun 2, 2022

Want to make sure I'm understanding what these designs indicate: we should display the image label (shelfmark + side) on the transcription and translation panels but only when they are viewed by themselves? Or only when the images are not showing?

That seems ok; some redundancy in the page, and we'll have to figure out how to handle transitions/spacing when showing and hiding that label, but make sense to provide the context.

fwiw, this will be messy with current transcription content, which sometimes duplicate this content. But that should be temporary, so I'm ok with it.

What are the implications for transcription + translation display?

  • @rlskoeser there were a lot of discussions for the transcription + translation layout but I don't think that factor was discussed! Thanks for flagging, I'll discuss with MR and RR

@gissoo
Copy link
Contributor Author

gissoo commented Jun 2, 2022

@gissoo - it might also help if Marina or I give you a more realistic example with the proper labels, as I think I'm also being thrown by the usage in the example. I'm happy to help right after today's meeting or next week.

@richmanrachel what I've used here is an example I found when I did keyword search for different margins, but please give me what you think would fit as realistic examples. We need to be consistent with the placement and the sizing of the shelfmark and the side info on all displays and MR expressed it's fine for them to be the same size, but I have also been wondering about the hierarchy between the side info and the margin info, I agree with your point on that. I'll pull this back to in-progress and will wait for you to give me some examples to work with.

@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label Jun 2, 2022
@rlskoeser
Copy link
Contributor

@gissoo @richmanrachel I actually don't think it's worth spending more time on this right now, because I expect that the headings and labels are going to change some when we get into the new transcription system. I haven't fully decided yet how I'm going to implement the labels, and I don't know yet if we'll have hierarchical information in the new model.

I'd like to move forward with this design and revisit if we need to once we know more about how the content will be structured.

@gissoo
Copy link
Contributor Author

gissoo commented Jun 3, 2022

@rlskoeser that's good to know, thanks for informing us about this, that is fine with me. And @richmanrachel I think it would be even better if we implement this version down the road and see what it looks like for various documents with the cases you have in mind, and make tiny revisions based on that if necessary then. The shelfmark I've used as an example in the designs will anyway be one of the actual cases, we'll get to see more variations when implemented.

I'll go ahead and close for now.

@gissoo gissoo closed this as completed Jun 3, 2022
@richmanrachel
Copy link

@gissoo and @rlskoeser - I agree with moving on. Just for future reference, I think the reason I was finding the example confusing is that all the different headers were used but they didn't capture the "body text" which we often haven't labeled separately. In the first fragment with a picture from the example above, the text that reads straight across midway down the page is the body and the angled text (that is physically above it but comes after it, content-wise) is the top margin:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

4 participants