-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design to view all images, or transcriptions, or translations together #783
Comments
@rlskoeser @mrustow @richmanrachel Please take a look at the screenshots below and let me know:
|
I need more context. Can we discuss IRT? |
|
|
@rlskoeser I have covered 2 different cases for this issue:
Please let me know if you notice any problems. |
Want to make sure I'm understanding what these designs indicate: we should display the image label (shelfmark + side) on the transcription and translation panels but only when they are viewed by themselves? Or only when the images are not showing? That seems ok; some redundancy in the page, and we'll have to figure out how to handle transitions/spacing when showing and hiding that label, but make sense to provide the context. fwiw, this will be messy with current transcription content, which sometimes duplicate this content. But that should be temporary, so I'm ok with it. What are the implications for transcription + translation display? |
@gissoo - can we use a different heading style for the shelfmark? It's a little confusing to have "recto" on the same line/in the same font size, but then have "verso" on its own line: |
@gissoo - it might also help if Marina or I give you a more realistic example with the proper labels, as I think I'm also being thrown by the usage in the example. I'm happy to help right after today's meeting or next week. |
|
@richmanrachel what I've used here is an example I found when I did keyword search for different margins, but please give me what you think would fit as realistic examples. We need to be consistent with the placement and the sizing of the shelfmark and the side info on all displays and MR expressed it's fine for them to be the same size, but I have also been wondering about the hierarchy between the side info and the margin info, I agree with your point on that. I'll pull this back to in-progress and will wait for you to give me some examples to work with. |
@gissoo @richmanrachel I actually don't think it's worth spending more time on this right now, because I expect that the headings and labels are going to change some when we get into the new transcription system. I haven't fully decided yet how I'm going to implement the labels, and I don't know yet if we'll have hierarchical information in the new model. I'd like to move forward with this design and revisit if we need to once we know more about how the content will be structured. |
@rlskoeser that's good to know, thanks for informing us about this, that is fine with me. And @richmanrachel I think it would be even better if we implement this version down the road and see what it looks like for various documents with the cases you have in mind, and make tiny revisions based on that if necessary then. The shelfmark I've used as an example in the designs will anyway be one of the actual cases, we'll get to see more variations when implemented. I'll go ahead and close for now. |
@gissoo and @rlskoeser - I agree with moving on. Just for future reference, I think the reason I was finding the example confusing is that all the different headers were used but they didn't capture the "body text" which we often haven't labeled separately. In the first fragment with a picture from the example above, the text that reads straight across midway down the page is the body and the angled text (that is physically above it but comes after it, content-wise) is the top margin: |
This issue includes:
Please review issues #782 and #784 before reviewing this issue.
The text was updated successfully, but these errors were encountered: