-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design a sub menu to contain more capabilities for transcriptions and translations #784
Comments
@rlskoeser @mrustow @richmanrachel Please take a look at the screenshots below. The only two sub menu items for the translation and transcription records are the ability to 1. Copy and 2. to select to view the translation/transcription by another editor. Questions for you:
sub menu items/controls when two toggles are selected |
Is the format of the editor drop-down intuitive? I know MR and RR suggested that we combine the Editor info and turn it into a drop down to let users select transcriptions/translations that way, is this format intuitive? And is the language intuitive? Let me know if you have suggestions (we have already decided on using one set of controls on desktop per page)
On mobile the controls are stacked and they appear above each record type, is this OK with you? I tried putting them next to each other initially but the size of the copy button won't be accessible.
The green checkmark style would appear on the copy button when selected and the intended behavior is then the green checkmark would go back to deselected (the outlined version) after a few seconds (using the green checkmark style as a way to indicate the user has successfully copied the content), is this OK implementation-wise/accessibility?
|
question:
|
Yes to "Translator." |
@rlskoeser @richmanrachel @mrustow thanks for writing.
|
@gissoo - regarding the first part, can you show me an example please? I'm having trouble understanding what you mean about truncating or seeing source title above the record without a visual. I think I agree, just want to double check! The copy design looks much better, thanks! |
@gissoo I'm fine with "editor: name" and "translator: name"; if there are any cases where editor is ambiguous, it should be pretty rare. (and maybe not any). I like the copy button, and like the choice to move it closer to the text. I'm not sure about the placement for the shelfmark, but can see the logic for putting it where you did. We may also want one for the top-level shelfmark on the document title. @richmanrachel if you see a copy button near transcription/translation, would you expect to get all the content or only the next page? My presumption is that you would prefer to get all the content at once, is that correct? |
@rlskoeser - yes, I'd like to copy all the content at once please. Thanks! |
@rlskoeser @richmanrachel Great! let me clarify: what I mean about the copy button's behavior (copy page-by-page vs. all) is that it's not clear to the user it that hitting that copy button would copy all the text, not just what they see on the page, till they paste it and find out. Is that OK? |
@gissoo - yes, I'd rather be surprised by getting more than not getting enough! |
@gissoo yes, I understood you concern. I see that, but think it will be obvious enough in practical use and I agree with Rachel that it's ok to err in that direction. Perhaps we can mitigate with title text on hover or something similar. |
@rlskoeser @richmanrachel @mrustow documenting some decisions here:
Also, @rlskoeser I will add the copy button styles to the components page on Figma. You can find all of the above in this Figma frame (used State Document; DK 256 (alt:XXI) as an example here because it's multi-authored). If you're all fine with these changes, I can close this issue. |
@gissoo - looks great! Thanks so much! |
@gissoo thanks for documenting! This all looks great to me. I'm glad my suggestions were helpful. Will be great to have copy button styles in Figma components for all states/interactions. I'm not sure when & how we will translate your designs into user stories to articulate all the functionality and design work to be built, but it would be great to make sure we document that copying the content should include the citation. (I think it should also include the permalink for the document.) |
the capabilities are:
The text was updated successfully, but these errors were encountered: