-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort automatically switches relevance whenever the search term is revised #827
Comments
I think this is actually one of the few times we can say "it's not a bug, it's a feature"! At least, it was planned that way. But perhaps we should revisit now that we have so many more sort options. Here is the original issue collecting the discussions: #550 Maybe it makes sense to only do this auto-switching to relevance when there isn't already a query in the text box. That way, you could "refine" a query search without impacting the sort option, but if you enter a new query search into a blank box, then it automatically chooses relevance. |
@blms - ahh, I see! That makes sense to me. Right now the auto-switch is just extra confusing since all the filters stick around. But I think your solution is on the right track. |
Right—maybe "filters applied" could be another condition that prevents the sort from auto-switching! |
I'm not sure I fully understand how that will work, but I trust you! |
@blms it works as we planned originally, but when we built it we didn't have so many sort options! I think maybe it should only change if you have the default sort selected. Also should probably only trigger if you go from no keyword text to some keyword text — not modified text, which I think it does now. I think it should not be aware of the filters, though. |
Fixed! Thank you :) |
testing notes (qa)
Describe the bug
When I add a new search term while trying to remain within Shelfmark A-Z sort, the site reverts the search to sort by Relevance.
dev notes
The text was updated successfully, but these errors were encountered: