Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the revised site header on mobile for the Latin site #871

Closed
1 task done
gissoo opened this issue May 17, 2022 · 1 comment
Closed
1 task done

Implement the revised site header on mobile for the Latin site #871

gissoo opened this issue May 17, 2022 · 1 comment
Assignees
@blms @gissoo

Comments

@gissoo
Copy link
Contributor

gissoo commented May 17, 2022 •
edited

testing notes (qa)

  • Confirm the site header looks right on mobile, light and dark mode

Here is the revised header on Figma

It's revised so that it matches with the desktop version.
@gissoo gissoo changed the title Implement the revised site header on mobile Implement the revised site header on mobile for the Latin site May 17, 2022
blms added a commit that referenced this issue May 17, 2022
@blms @gissoo
Revise assets for light mobile header (#871, #872)
03fd080 
Co-authored-by: gissoo <44615389+gissoo@users.noreply.github.com>
blms added a commit that referenced this issue May 17, 2022
@blms
Revise styles for mobile header (#871, #872)
58bca67
blms added a commit that referenced this issue May 17, 2022
@blms @gissoo
Revise assets for dark mobile header (#871, #872)
47471a1 
Co-authored-by: gissoo <44615389+gissoo@users.noreply.github.com>
blms added a commit that referenced this issue May 17, 2022
@blms
Revise styles for mobile dark header (#871, #872)
67b12ab
blms added a commit that referenced this issue May 17, 2022
@blms
Lighten green gradient in mobile light header base
eab02a9 
ref #871
@blms blms mentioned this issue May 17, 2022
Merged
blms added a commit that referenced this issue May 17, 2022
@blms
Merge pull request #878 from Princeton-CDH/feature/871-revised-header…
59c5e46 
…-mobile

Revised mobile header (#871, #872)
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label May 17, 2022
@gissoo
Copy link
Contributor Author

gissoo commented May 17, 2022

@blms amazing!!! Thank you

@gissoo gissoo closed this as completed May 17, 2022
@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label May 18, 2022
rlskoeser pushed a commit that referenced this issue Jun 15, 2022
@blms @gissoo @rlskoeser
Revise assets for light mobile header (#871, #872)
0e8dd5c 
Co-authored-by: gissoo <44615389+gissoo@users.noreply.github.com>
rlskoeser pushed a commit that referenced this issue Jun 15, 2022
@blms @rlskoeser
Revise styles for mobile header (#871, #872)
fb8cb4d
rlskoeser pushed a commit that referenced this issue Jun 15, 2022
@blms @gissoo @rlskoeser
Revise assets for dark mobile header (#871, #872)
af5c103 
Co-authored-by: gissoo <44615389+gissoo@users.noreply.github.com>
rlskoeser pushed a commit that referenced this issue Jun 15, 2022
@blms @rlskoeser
Revise styles for mobile dark header (#871, #872)
098dc9a
rlskoeser pushed a commit that referenced this issue Jun 15, 2022
@blms @rlskoeser
Lighten green gradient in mobile light header base
7a4b585 
ref #871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blms blms

@gissoo gissoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rlskoeser @blms @gissoo