Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I want to toggle content panels so that I can view image or transcription separately or both at the same time, so I can read the content I am interested in. #893

Closed
6 tasks done
rlskoeser opened this issue May 27, 2022 · 3 comments
Assignees

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented May 27, 2022

testing notes

On a document that has both image and transcription, test the panel toggle controls and try looking at:

  • image + transcription side by side
  • images only
  • transcription only

dev notes

  • clicking button should toggle panel visibility
  • revise transition styles (image height transition is too much on top of grid panel sliding closed; maybe separate with a delay so the image transition isn't visible?)
  • style toggles with images from the design and to reflect state (on/off)
@rlskoeser rlskoeser self-assigned this May 27, 2022
@rlskoeser rlskoeser changed the title As a user I want to be able to toggle content panels so that I can view image or transcription separately or both at the same time, so I can read the content I am interested in. As a user I want to toggle content panels so that I can view image or transcription separately or both at the same time, so I can read the content I am interested in. May 27, 2022
@gissoo
Copy link
Contributor

gissoo commented May 28, 2022

@rlskoeser @blms here are the revised toggles for desktop and mobile on Figma

here you can see what it looks like when all toggles are deselected on desktop and mobile

I have uploaded the toggles on google drive here, because I had a lot of questions on how to organize them on github –

note:

  • the image toggles are in PNG and the transcription and translation toggles are in SVG
  • selected/active toggles on desktop are 65 x 65px, and deselected toggles on desktop are the same size as mobile toggles which is 40 x 40px. all toggles on mobile always maintain the same size.

blms added a commit that referenced this issue May 31, 2022
Co-authored-by: gissoo <44615389+gissoo@users.noreply.github.com>
blms added a commit that referenced this issue May 31, 2022
@blms blms self-assigned this May 31, 2022
blms added a commit that referenced this issue Jun 1, 2022
blms added a commit that referenced this issue Jun 1, 2022
blms added a commit that referenced this issue Jun 2, 2022
…ption-panel

Style image/transcription/translation panel (#889, #892, #893)
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Jun 10, 2022
blms added a commit that referenced this issue Jun 13, 2022
@richmanrachel
Copy link

@rlskoeser and @gissoo - the functionality is great! The difference between "not open" and "not available" may be a little too subtle still: could we add crosshatching or something on "not available"?

image

@richmanrachel
Copy link

Closing and opening a separate design issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants