Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content editor I want to use basic formatting in transcription content so that I can enter lines as numbered lists or tag when the language changes within a document. #916

Closed
9 tasks done
rlskoeser opened this issue Jun 9, 2022 · 5 comments
Assignees

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Jun 9, 2022

Testing notes (qa)

After testing #911, confirm that when you start editing an annotation body, you can use:

  • line breaks
  • numbered lists
  • language tags
  • strikethroughs

Also confirm

  • you can save formatted changes
  • saved content with formatting displays when you reload the page

dev notes

integrate tinymce editor into tahqiq text editing block

revisions after testing:

  • style superscript/subscript
  • style lists
  • allow deleting empty content annotations

glitch prototype:

@blms blms self-assigned this Jul 11, 2022
blms added a commit that referenced this issue Jul 13, 2022
rlskoeser added a commit that referenced this issue Jul 13, 2022
Include TinyMCE from CDN in transcribe view (#916)
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Jul 21, 2022
@richmanrachel
Copy link

This mostly works perfectly! The only feature that works in the edit field but doesn't save as such is the superscript.

The language tags stayed with the highlighted text even when I had two languages in the same transcription zone :)

@rlskoeser and @blms - should I close because the testing features above worked, or mark as tested needs attention since there's still one available feature that doesn't save properly?

@rlskoeser
Copy link
Contributor Author

@richmanrachel I suspect we are missing styles for that tag (similar to the list), so we should kick it back and fix that before closing.

Can you elaborate what you meant about the language tags staying with the highlighted text?

@rlskoeser rlskoeser added ⚠️ tested needs attention Has been through acceptance testing and needs additional work and removed 🗜️ awaiting testing Implemented and ready to be tested labels Jul 25, 2022
@richmanrachel
Copy link

@rlskoeser - great, thanks!

I meant that when I closed a transcription and re-opened it, that I could click the text and the language feature was highlighted and maintained the difference between the Hebrew and Arabic text blocks (this screen shot isn't great, but you can see that the language switcher is darker than normal because it's been activated)
image

@rlskoeser
Copy link
Contributor Author

@richmanrachel thanks for explaining — that's great to hear, and a good confirmation that it's working as hoped.

blms added a commit that referenced this issue Jul 26, 2022
blms added a commit that referenced this issue Jul 27, 2022
blms added a commit that referenced this issue Jul 27, 2022
Fix missing styles on transcription editor (#916)
@blms blms added 🗜️ awaiting testing Implemented and ready to be tested and removed ⚠️ tested needs attention Has been through acceptance testing and needs additional work labels Aug 2, 2022
@richmanrachel
Copy link

It works! Just want to bring to @gissoo's attention that the strikethrough lines through this Arabic font make the original word hard to read (sorry for the gibberish!)
image

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants