Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all #FFFFFF text in dark mode to #F7F7F7 for accessibility reasons #931

Closed
1 task done
gissoo opened this issue Jun 22, 2022 · 1 comment
Closed
1 task done

Change all #FFFFFF text in dark mode to #F7F7F7 for accessibility reasons #931

gissoo opened this issue Jun 22, 2022 · 1 comment
Assignees
@blms @gissoo
Labels
♿ accessibility Impacts access for some users

Comments

@gissoo
Copy link
Contributor

gissoo commented Jun 22, 2022 •
edited

testing notes (qa)

  • In dark mode on QA, confirm lightest text is #f7f7f7
@gissoo gissoo added the ♿ accessibility Impacts access for some users label Jun 22, 2022
@blms blms self-assigned this Jul 7, 2022
blms added a commit that referenced this issue Jul 7, 2022
@blms
Change dark mode #fff to #f7f7f7 (#931)
7b81e35 
[run percy]
@blms blms mentioned this issue Jul 7, 2022
Merged
blms added a commit that referenced this issue Jul 7, 2022
@blms
Update selenium webdriver code to fix deprecation
92b5140 
ref #931
[run percy]
blms added a commit that referenced this issue Jul 7, 2022
@blms
Merge pull request #938 from Princeton-CDH/feature/931-white-accessib…
722188a 
…ility

Change dark mode #fff to #f7f7f7 (#931)
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Jul 8, 2022
@gissoo gissoo closed this as completed Jul 8, 2022
@gissoo gissoo removed the 🗜️ awaiting testing Implemented and ready to be tested label Jul 8, 2022
@gissoo
Copy link
Contributor Author

gissoo commented Jul 8, 2022

@blms thanks!! Everything looks great for this issue!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blms blms

@gissoo gissoo

Labels
♿ accessibility Impacts access for some users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blms @gissoo