Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content editor working in the admin interface, I want a warning/error if I try to save a new document without a shelfmark. #935

Closed
richmanrachel opened this issue Jul 6, 2022 · 2 comments
Assignees
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant

Comments

@richmanrachel
Copy link

richmanrachel commented Jul 6, 2022

testing notes

On the QA site, try to create a document without attaching any fragments. It should display an error when you try to save it.


Background: Yusuf thought he was running into a bug when he was adding new documents and they were attached to "related documents" on the front end. But the issue is that he was using the shelfmark override to input the shelfmark, rather than using the "related fragments" field to properly connect the fragments field in the relational database. While investigating, Rachel discovered that other users had made the same mistake, resulting in 14 documents that were technically fragment-less.

Proposal: Some kind of error message or genuine error that prevents saving a new document entry without a related fragment. RR doesn't have a strong preference for how this is done, but we do want the user to be made aware so that we don't have any fragment-less documents.

@richmanrachel richmanrachel added the 🐛 bug Something isn't working label Jul 6, 2022
@kseniaryzhova kseniaryzhova added the performant Tasks for or taken on by Performant label Nov 23, 2022
@blms blms self-assigned this Dec 21, 2022
blms added a commit that referenced this issue Dec 22, 2022
In order to show error on new document without fragment
ref #935
blms added a commit that referenced this issue Jan 13, 2023
Show an error on saving a new document without a fragment (#935)
@blms blms added 🆕 enhancement New feature or request 🗜️ awaiting testing Implemented and ready to be tested and removed 🐛 bug Something isn't working labels Jan 13, 2023
@kseniaryzhova
Copy link

@blms I wasn't able to even click create document - sent me a server error message:
image

@kseniaryzhova
Copy link

@blms works now! Closing, thank you!

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 enhancement New feature or request performant Tasks for or taken on by Performant
Projects
None yet
Development

No branches or pull requests

4 participants