Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin footnote download results in an empty csv file (headers only) #946

Closed
rlskoeser opened this issue Jul 14, 2022 · 3 comments
Closed

admin footnote download results in an empty csv file (headers only) #946

rlskoeser opened this issue Jul 14, 2022 · 3 comments
Assignees
@rlskoeser
Labels
🐛 bug Something isn't working

Comments

@rlskoeser
Copy link
Contributor

Describe the bug
Attempted to download csv file for footnote data and got an empty csv that included the headers but no content. Happened whether I tried to download all using the button or selected a set and download jest a portion

To reproduce
Steps to reproduce the behavior:

  1. Log in to admin
  2. Navigate to scholarship records > footnotes
  3. Click "download all as csv" OR select some records and choose action "export selected records to CSV" and hit go
  4. Downloaded file contains headers but no content

Expected behavior
Downloaded file should include information for all or selected footnotes
@rlskoeser rlskoeser added the 🐛 bug Something isn't working label Jul 14, 2022
@rlskoeser rlskoeser self-assigned this Jul 14, 2022
rlskoeser added a commit that referenced this issue Jul 14, 2022
@rlskoeser
Update footnote admin export for current TEI text
82c15c6 
addresses #946

Also adds document pk as a separate field,
to make it easier to combine with document export
rlskoeser added a commit that referenced this issue Jul 14, 2022
@rlskoeser
Update footnote admin export for current TEI text
193c881 
addresses #946

Also adds document pk as a separate field,
to make it easier to combine with document export
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Jul 14, 2022
@richmanrachel
Copy link

@rlskoeser - by "content" do you mean any content or what belongs under the "content" header? here's what the sample I just downloaded looks like:
image

@rlskoeser
Copy link
Contributor Author

@richmanrachel whoops, sorry for being unclear — I mean any rows other than the header row. In production I only got the header row and nothing else. This looks reasonable to me!

@richmanrachel
Copy link

@rlskoeser - great! Closing :)

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlskoeser rlskoeser

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlskoeser @richmanrachel