-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The public search bar has a bias towards LTR text that makes it challenging/unintuitive to search in RTL and especially to use wildcards with RTL. #948
Comments
@richmanrachel thanks for this. Can you add that search string or link (or one like it) in a format that I can cut and paste so I can experiment with it? I had an idea about this problem with the search input and was thinking about it again in relation to the Startwords piece on the Zooniverse Geniza keyboards https://startwords.cdh.princeton.edu/issues/2/strangers-in-the-landscape/ I'm wondering if we might want to override / explicitly set the text direction on the input instead of letting the browser decide (but we'll have to figure out when/how). Another option is to convert the LTR versions of queries like this into the format that Solr needs to interpret them properly. |
@rlskoeser - yes, thank you! 10~"גזל עמל" I'm open to options for how to solve this |
@richmanrachel I asked about this on DHTech Slack and got the suggestion to set the text direction to |
@rlskoeser - this is working so much better, thank you! There are still some problems - you can't use quotations around Arabic phrases that convert to Judaeo Arabic (ex. "ثوب دبيقي" should return the 11 results for "תוב דביקי"). But the proximity search is working with Hebrew script and it's even easy to add boolean operators in Latin between Hebrew/Arabic words! |
Works! Closing! @richmanrachel is writing a new issue for Arabic quotation mark bug. |
Describe the bug
When trying to search the frontend of the PGP for my research, I'm struggling to input and edit RTL text. For example, I realized that when I input דלאלה (dalāla, "broker"), I was only getting 6 results and none of them included the famous woman known as Wuhsha al-Dalāla. When I tried to add the prefix "al-" (="the"), I had to retype the entire term multiple times, because when I tried to just add the prefix, it moved to the back of the word.
Then I tried adding an * for a wildcard search, and I tried to put it in front of the word, but it yielded no new results. When I tried again just now to experiment, I did get 24 results when the * went at the end of the word.
Is it possible for the search bar to intuit RTL text and work in the correct direction so that wildcards can be placed in the expected location?
To reproduce
Steps to reproduce the behavior:
Expected behavior
I expect that like when typing in English, if my space bar is at the end of the word, the next letters I type will show up after the space bar (and not jump to the front of the word). And vice versa, if my cursor is at the beginning of the word, my next letters will show up at the front of the word.
I also think (but could be wrong) that wildcards are supposed to go at the beginning or end of the search term depending on where you expect/want to see additional content. But the LTR bias is making the wildcard only work on the "wrong" side of the search term.
Screenshots
Device information
The text was updated successfully, but these errors were encountered: