-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a content editor, when I select a fragment “side” in the document edit form I want an indicator of which fragment images will be displayed so that I can confirm I’m selecting the correct side or sides. #955
Comments
@mrustow or @richmanrachel how do you use (or want to use) the Here are a few shelfmarks with more than two images in case it's helpful to look at examples (let me know if you want the whole list):
In my local development data (which is probably slightly out of sync) I found 293 IIIF manifests with more than two associated canvases out of 15,455 total cached manifests. |
@rlskoeser - yes, being able to carve out a subset would be helpful! For ex. I do not know why T-S Ar.54.46 was put together as a single shelfmark because there seem to be two different documents on the different fragments... Or.1081 J56 is functionally a library made join and there only happens to be text on the recto side of both fragments. |
@richmanrachel are these cases where you'd want to make a custom iiif manifest, like Alan and I discussed on #701 ? Or is this a case where the manifest is fine but you want to select which images from it are relevant? We'll need to discuss how to support selecting images in cases that are not simple recto/verso, I'm not sure how to approach it. |
@rlskoeser - I don't think I can make a decision about this without further discussion. Is this a blocker for what you're trying to get out today? Or can we discuss it next week? |
@richmanrachel Not a blocker, and agreed we should discuss. We'll work on the implementation for the simple cases for now, which will hopefully give us all more context for thinking about the other cases. |
Works! |
testing notes (qa)
In the admin edit form for a document, in the "related fragments" section, change the selected "Side" for a fragment connected to the document. Save your changes on the document, and scroll back down to the fragments section. There:
dev notes
Side information is stored in
TextBlock.side
and can currently be recto, verso, or both.Fragment.iiif_thumbnails
method used in the textblock inline display to add a class for selected image based on side. (For now assume recto / verso matches iiif image order).The text was updated successfully, but these errors were encountered: