-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user, I want the full citation for a transcription in context so I know who authored it and where it came from. #959
Comments
We are indeed using the same short citation format that is used in the metadata section. A few things I noticed:
|
@blms I think we should use the formatted citation. Maybe it's easier (except for layout/spacing) if we use the formatted version — the I think the min-height really only comes into play with documents that have more than one transcription. Maybe that helps us somehow with how we approach it? |
Love it! Closing :) |
Reopening due to the issue I found with links, marking as tested needs attention too |
Unmark HTML safe in data attribute (#959)
tested switching between editions on pgpid 606 and pgpid 9121, I think it's behaving as expected; links are preserved and display properly after switching |
testing notes (qa)
known revisions needed
dev notes
Transcription citation should be displayed in gray at the top of the transcription panel.
This was already implemented in an earlier phase even though it was not mvp, but I'm not sure it was tested directly and I noticed in passing some citations that didn't look correct. Let's check the dev implementation and be sure we're using the correct citation and then test it with all source variations.
The text was updated successfully, but these errors were encountered: