Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine logic for identifying transcription chunks that indicate new image #995

Closed
2 tasks done
rlskoeser opened this issue Jul 29, 2022 · 10 comments
Closed
2 tasks done
Assignees
Labels
🛠️ chore One-off task or update

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Jul 29, 2022

dev notes

@rlskoeser rlskoeser added the 🛠️ chore One-off task or update label Jul 29, 2022
@richmanrachel
Copy link

Hebrew label for "margins" should NOT indicate new page (but noting for convenience here): שוליים

@rlskoeser rlskoeser self-assigned this Aug 16, 2022
@rlskoeser
Copy link
Contributor Author

@richmanrachel I looked at PGPID 3573 and noticed that ע“ב didn't look like it was tagged as a label. I checked the TEI to confirm, and then did a quick search and I found 66 xml documents total where this text is tagged as a line instead of a label, i.e.:
<l n="">ע"ב</l>

Is it appropriate to convert all of these to <label> tags ?

@richmanrachel
Copy link

@rlskoeser - yes, please convert those to labels! This will be a huge help :)

rlskoeser added a commit that referenced this issue Aug 16, 2022
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Aug 17, 2022
@richmanrachel
Copy link

@rlskoeser - it doesn't seem to be working :( https://test-geniza.cdh.princeton.edu/en/documents/3573/

@rlskoeser
Copy link
Contributor Author

@richmanrachel oh no! I thought it worked properly when I ran it locally, once I changed the lines to labels; will have to investigate

@richmanrachel
Copy link

@rlskoeser - Bummer! But the 1546 labels with ENA, etc, are working :)

@richmanrachel richmanrachel added ⚠️ tested needs attention Has been through acceptance testing and needs additional work and removed 🗜️ awaiting testing Implemented and ready to be tested labels Aug 17, 2022
@rlskoeser
Copy link
Contributor Author

@richmanrachel it's a smart quotes / straight quotes problem! The original version you gave me used a smart quote, and that's what I'm checking for in my code, but when I did my search and replace I must have converted to straight quotes. Which one do you want in the transcription label?

@richmanrachel
Copy link

@rlskoeser - oy vey, the smart quotes strike again! The instructions on PPA only showed how to override them on iPhones, not Macs, and so I didn't go deeper...

You might need the transcription label to have both versions, so we don't run into this problem - is that possible?

@rlskoeser
Copy link
Contributor Author

@richmanrachel yes, I'll revise so it works with both variants

@rlskoeser rlskoeser added 🗜️ awaiting testing Implemented and ready to be tested and removed ⚠️ tested needs attention Has been through acceptance testing and needs additional work labels Aug 18, 2022
@richmanrachel richmanrachel removed the 🗜️ awaiting testing Implemented and ready to be tested label Aug 18, 2022
@richmanrachel
Copy link

@rlskoeser - fixed! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

2 participants