Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I'd like to select the plaque on the trunk of the tree to learn about the data on "dedication" #106

Closed
gissoo opened this issue Mar 13, 2023 · 18 comments
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Mar 13, 2023

what's in scope:

  • the logic of the interaction between the plaque and the panel
  • the content/fields inside of the panel
  • the visual styles of the plaque states
@gissoo gissoo added the 🗺️ design Tracks design work in an external app label Mar 13, 2023
@gissoo gissoo self-assigned this Mar 13, 2023
@gissoo gissoo added the 💬 awaiting review Ready for comments and questions label Mar 13, 2023
@gissoo
Copy link
Contributor Author

gissoo commented Mar 13, 2023

@jhimpele @rlskoeser Look above in the issue description for what's in scope of this issue
The logic of the interaction here is the same as a leaf (note and questions below):

  • Once the plaque is selected the panel would expand

  • does this data point have any tags?

  • do we want to specify "Trunk" where we normally see "Branch" inside the panel?

  • do we want to display a year for the panel and by the trunk?

  • @jhimpele currently I've placed the longer label you'd given me inside the panel as text – is this the right place for it, or will it be the title inside the panel?

  • I propose a visual style for the hovered and selected plaque where the plaque is crooked by default but on hover and select it becomes straight with a black outline. What do you think? I'd like the visual style to be a bit different from the leaves because a glow doesn't visually work here with a brown plaque. I'm open to suggestions

@jhimpele
Copy link
Contributor

@gissoo @rlskoeser
Responses:

  • what does "expand" mean? The panel displays the dedication text?
  • we could add tags, but not necessary.
  • Can we leave the Trunk or Branch label blank, so neither appears?
  • No year needed
  • Sorry, can you send the longer label you have as text so we can edit it into a title for the panel?
  • I like this interaction when hover/select. Though I'd go with dark brown instead of black for the outline, to match the same coloring on selected leafs that have a darker color. Or, could there be a small glow like the leaves?

@rlskoeser
Copy link
Contributor

@gissoo I think the details for the dedication should be simpler — no "trunk" label, no tags, no year. Just a title, brief paragraph text, and photo. It's different from the leaves, and it stands alone, so it doesn't make sense to me to use the structures/metadata we have for the other items.

The crooked panel looks a little strange to me; maybe if you make the nail a little more obvious it would work better. Why would it straighten out on hover? (It doesn't seem logical for a sign on a tree to turn like that.)

@jhimpele
Copy link
Contributor

jhimpele commented Mar 20, 2023 via email

@gissoo
Copy link
Contributor Author

gissoo commented Mar 22, 2023

@rlskoeser @jhimpele please take a look here – your comments are very helpful, thank you – I've revised the behavior on select and the the panel details so that it looks like the project description panel in format

@gissoo
Copy link
Contributor Author

gissoo commented Mar 22, 2023

@jhimpele the dedication title in the google document is "Dedicated to Karen Dolson Mosko, Lunaape Language Teacher, Munsee Delaware Nation"

this seems to be the description? ' "I am blessed to be led by my ancestors to teach our language. This is a path that I will walk for the rest of my life." -- Karen Mosko '

@jhimpele
Copy link
Contributor

I'm not sure if I am seeing the Dedication panel.

I think the Panel title could just be "This work is dedicated to Karen Dolson Mosko (1968-2022)"

Then a subheading on a new line (in the body) below her name:
"Lunaape Language Teacher, Munsee Delaware Nation"

Then in the body (description):
"I am blessed to be led by my ancestors to teach our language. This is a path that I will walk for the rest of my life."

  • Karen Mosko

Read Karen Mosko'obituary [https://elliottmadill.com/tribute/details/816/Karen-Mosko/obituary.html#content-start]

@rlskoeser
Copy link
Contributor

@gissoo the panel and interaction looks good to me.

I think you have the string for the plaque upside down, I imagined something more like this:

   o
  / \
 /   \
-------
|      |
-------

@gissoo
Copy link
Contributor Author

gissoo commented Mar 22, 2023

@jhimpele @rlskoeser Since it looks like we are agreeing to revise the background color of this page I was able to try the glow as well – it wouldn't work on the lighter color.

@jhimpele
Copy link
Contributor

jhimpele commented Mar 22, 2023 via email

@rlskoeser
Copy link
Contributor

@gissoo I like the glow!

@gissoo
Copy link
Contributor Author

gissoo commented Mar 22, 2023

ah thanks for illustrating, @rlskoeser :D – let me try it quickly. I don't really like putting a nail on the trunk for a plaque, I don't find it necessary (also feels a little harsh), I've been looking at so many examples that don't involve a nail.

@jhimpele
Copy link
Contributor

@gissoo I'm now seeing the space constraints on the dedication panel, and want to suggest this:

This work is dedicated to the memory of
Karen Dolson Mosko (1968-2022)

Lunaape Language Teacher, Munsee Delaware Nation

"I am blessed to be led by my ancestors to teach our language. This is a path that I will walk for the rest of my life."

Read Karen Mosko's obituary [https://elliottmadill.com/tribute/details/816/Karen-Mosko/obituary.html#content-start]

[Use what ever sizing makes visual sense]

@jhimpele
Copy link
Contributor

I wrote separately, but I am fine with the less destructive approach without the nail.

@gissoo
Copy link
Contributor Author

gissoo commented Mar 22, 2023

@rlskoeser @jhimpele I quickly created what Rebecca has shown, I'm sorry but I really dislike this :( ...it looks like a store (open/closed) sign

@jhimpele
Copy link
Contributor

Good point about the tree growing beyond the string, @rlskoeser. But since I now don't have really strong feelings I would defer to @gissoo. (Of the strings, I still prefer the second one.)

@rlskoeser
Copy link
Contributor

@gissoo @jhimpele I don't feel strongly (unless implementation turns out to be difficult for some reason); let's move on with whatever you think is best.

@gissoo
Copy link
Contributor Author

gissoo commented Mar 22, 2023

@rlskoeser @jhimpele for the scope of this issue I think I've revised the dedication panel and simplified it. I think we also like the glow that would work on the new darker page background color. I'll go ahead and close this issue. Let me know if you think of something else and I'll resolve it in a new issue.

@gissoo gissoo closed this as completed Mar 22, 2023
@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants