-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user I'd like to select the plaque on the trunk of the tree to learn about the data on "dedication" #106
Comments
@jhimpele @rlskoeser Look above in the issue description for what's in scope of this issue
|
@gissoo @rlskoeser
|
@gissoo I think the details for the dedication should be simpler — no "trunk" label, no tags, no year. Just a title, brief paragraph text, and photo. It's different from the leaves, and it stands alone, so it doesn't make sense to me to use the structures/metadata we have for the other items. The crooked panel looks a little strange to me; maybe if you make the nail a little more obvious it would work better. Why would it straighten out on hover? (It doesn't seem logical for a sign on a tree to turn like that.) |
I concur with both of Rebecca’s points here.
|
@rlskoeser @jhimpele please take a look here – your comments are very helpful, thank you – I've revised the behavior on select and the the panel details so that it looks like the project description panel in format |
@jhimpele the dedication title in the google document is "Dedicated to Karen Dolson Mosko, Lunaape Language Teacher, Munsee Delaware Nation" this seems to be the description? ' "I am blessed to be led by my ancestors to teach our language. This is a path that I will walk for the rest of my life." -- Karen Mosko ' |
I'm not sure if I am seeing the Dedication panel. I think the Panel title could just be "This work is dedicated to Karen Dolson Mosko (1968-2022)" Then a subheading on a new line (in the body) below her name: Then in the body (description):
Read Karen Mosko'obituary [https://elliottmadill.com/tribute/details/816/Karen-Mosko/obituary.html#content-start] |
@gissoo the panel and interaction looks good to me. I think you have the string for the plaque upside down, I imagined something more like this:
|
@jhimpele @rlskoeser Since it looks like we are agreeing to revise the background color of this page I was able to try the glow as well – it wouldn't work on the lighter color. |
That is what I had in mind, too. Well done Rebecca.
|
@gissoo I like the glow! |
ah thanks for illustrating, @rlskoeser :D – let me try it quickly. I don't really like putting a nail on the trunk for a plaque, I don't find it necessary (also feels a little harsh), I've been looking at so many examples that don't involve a nail. |
@gissoo I'm now seeing the space constraints on the dedication panel, and want to suggest this: This work is dedicated to the memory of Lunaape Language Teacher, Munsee Delaware Nation "I am blessed to be led by my ancestors to teach our language. This is a path that I will walk for the rest of my life." Read Karen Mosko's obituary [https://elliottmadill.com/tribute/details/816/Karen-Mosko/obituary.html#content-start] [Use what ever sizing makes visual sense] |
I wrote separately, but I am fine with the less destructive approach without the nail. |
@rlskoeser @jhimpele I quickly created what Rebecca has shown, I'm sorry but I really dislike this :( ...it looks like a store (open/closed) sign |
Good point about the tree growing beyond the string, @rlskoeser. But since I now don't have really strong feelings I would defer to @gissoo. (Of the strings, I still prefer the second one.) |
@rlskoeser @jhimpele for the scope of this issue I think I've revised the dedication panel and simplified it. I think we also like the glow that would work on the new darker page background color. I'll go ahead and close this issue. Let me know if you think of something else and I'll resolve it in a new issue. |
what's in scope:
The text was updated successfully, but these errors were encountered: