Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design a visual style for the single data point on the trunk of the tree so that users can learn about its distinction from the rest of the leaves #91

Closed
gissoo opened this issue Feb 27, 2023 · 13 comments
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Feb 27, 2023

No description provided.

@gissoo gissoo added the 🗺️ design Tracks design work in an external app label Feb 27, 2023
@gissoo gissoo self-assigned this Feb 27, 2023
@gissoo
Copy link
Contributor Author

gissoo commented Mar 8, 2023

@jhimpele @rlskoeser before I move too far ahead with styles for interaction, and functionality details could you please review these proposals for the visual style of the trunk data?

Note: two of the proposals are plaques and one is a type of small opening of the tree – I don't know what it is exactly called.

  • is there any way we could put a meaningful, short text that would fit on the visual element/plaque in addition to the label?
  • Is this the shortest the label can be?

@gissoo gissoo added the 💬 awaiting review Ready for comments and questions label Mar 8, 2023
@jhimpele
Copy link
Contributor

jhimpele commented Mar 9, 2023

@gissoo My favorite style is number two in the darker shade, which would allow a bright font for a short label. What do you think of having it hang from a nail, instead of wrapped around the tree? Some thoughts about the text. What if it only said, "Dedication" and then hovering reveals the text you have plus the content quote?

@rlskoeser
Copy link
Contributor

@gissoo I like one or two. I think a plaque is preferable to a the designs that look like a hole or feature of the tree itself. I agree with Jeff that a nail would be better than a cord around the tree.

I thought we decided the interaction would be like the leaves — clicking on the visual would open the details in the panel, the same way that leaf details are shown. I don't remember if we discussed labels for this, but I think it should be something short (like just "dedication") if it needs to be labeled at all. I would be nice if the visual was enough without a text label to convey meaning and invite clicking on it, but I'm ok with a text label if that works better.

@jhimpele
Copy link
Contributor

jhimpele commented Mar 13, 2023 via email

@gissoo
Copy link
Contributor Author

gissoo commented Mar 13, 2023

@jhimpele @rlskoeser Amazing! YES! a shorter / display label like "Dedication" would be perfect! it's just what I was hoping for.

So please review this revised version with a nail and let me know what you think

I'll open a new issue about the interaction part.

@jhimpele
Copy link
Contributor

Better with the nail, @gissoo. How about a short string (upside down V) that hangs the plaque from the nail? Also, it doesn't necessarily have to be straight horizontal, if you want to give it a slight angle.

@rlskoeser
Copy link
Contributor

The nail is better but not visible enough; I think it either needs more contrast or separation via a string as Jeff suggested.

@gissoo
Copy link
Contributor Author

gissoo commented Mar 22, 2023

@rlskoeser @jhimpele thanks for writing. I've gone back to my original proposal with the strings again since the nail is not going to be visible, and nail with a string doesn't visually make sense.

Please look at these two styles and let me know if you like either one

@jhimpele
Copy link
Contributor

jhimpele commented Mar 22, 2023 via email

@rlskoeser
Copy link
Contributor

Commented on the other issue about the string before I saw this one - #106 (comment)

How does a nail with a string not make sense? I think it's more common to hang a sign from a string on a nail than to run it around the girth of the tree, esp. since the size of the tree will change as it ages. (-- although a quick google image search is turning up things more like what you've designed!)

@jhimpele
Copy link
Contributor

jhimpele commented Mar 22, 2023 via email

@gissoo
Copy link
Contributor Author

gissoo commented Mar 22, 2023

@rlskoeser Right, I mainly saw versions without a nail. Aesthetically I prefer it. Thanks for pointing out the harm of a string, super helpful! Now I don't feel strongly :D ...still not my aesthetic but it doesn't have to be, that's why we have this review process.

@gissoo
Copy link
Contributor Author

gissoo commented Mar 22, 2023

@jhimpele @rlskoeser thank you for your feedback on this. Based on your comments here and in #106 I propose that we go with proposal 2, the version with the string that Jeff preferred. I'm archiving the other version with the nail so we can revisit if the implementation is complicated or if you absolutely hate it in a few days.

@gissoo gissoo closed this as completed Mar 22, 2023
@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants