Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup an assortment small visual issues #109

Closed
6 tasks done
quadrismegistus opened this issue Mar 21, 2023 · 3 comments
Closed
6 tasks done

cleanup an assortment small visual issues #109

quadrismegistus opened this issue Mar 21, 2023 · 3 comments
Assignees
Labels
🛠️ chore One-off task or update

Comments

@quadrismegistus
Copy link
Contributor

quadrismegistus commented Mar 21, 2023

  • Horizontal scroll activates on main page when it probably shouldn’t
    • I actually can't recreate this anymore?
    • Actually I can, only when the detail window is closed, then all the sudden both scrollbars appear on the page even though not necessary
    • Now I can't again?
  • Horizontal scroll activates on the text info window due to a URL; should probably disable overflow
  • Horizontal and vertical scroll have the scrollbar space at right and bottom there even when not needed
  • Cursor doesn’t need to shift to the text cursor when hovering leads
  • Unicode error (curly quotes)
    • This one also just disappeared and started rendering correctly!?
  • Escape closes detail panel
@quadrismegistus
Copy link
Contributor Author

quadrismegistus commented Mar 21, 2023

Turning overflow off for horizontal scroll in #panel does this, with overflow auto on vertical scroll, does this:

Screen Shot 2023-03-21 at 12 34 00 PM

Should we pad the right a bit more?

Incidentally that X could prob be more top right aligned?

@rlskoeser
Copy link
Contributor

sorry, just seeing your comments now — I think the links will probably be fixed via content editing.

The X hasn't been styled & positioned based on the designs; this is just a quick version I threw in so I could work on functionality. Implementation issue for that is #84 if you have any interest in taking it on.

Should we close this based on merging #116 ?

@rlskoeser rlskoeser added the 🛠️ chore One-off task or update label Mar 23, 2023
@rlskoeser rlskoeser changed the title Assortment of small visual issues recently noticed by RH cleanup small visual issues Mar 23, 2023
@rlskoeser rlskoeser changed the title cleanup small visual issues cleanup an assortment small visual issues Mar 23, 2023
@rlskoeser
Copy link
Contributor

going to close this as done, we can open new issues as needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

2 participants