Implement the close button for the leaf panels #84
Assignees
Labels
🛠️ chore
One-off task or update
Comments
6 tasks
rlskoeser
added a commit
that referenced
this issue
Mar 28, 2023
- more semantic names for panel content sections - close button positioning/styling #84 - split out panel styles into a component csss file - make close button more accessible
7 tasks
rlskoeser
added a commit
that referenced
this issue
Apr 4, 2023
* Adjust panel size and placement on mobile #52 Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com> * Fix debug control panel positioning * Update colors for header/footer/panel and add panel box shadow #125 * Add phosphor icons; adjust panel styles and close button position * Revise panel styles - more semantic names for panel content sections - close button positioning/styling #84 - split out panel styles into a component csss file - make close button more accessible * Add leaf icon to branch in leaf details * Fix selected leaf hash bug * Update unit tests for changes to container names * Update visual testing selected leaf id, run in production mode * Fix icon mask size on chrome; set max height for panel on desktop * Adjust panel height and tree top margin on mobile Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com> * Revise panel styles and adjust layout * Add label to placeholder tag so it won't cause lighthouse ci to fail * Add overflow wrapping within panel text --------- Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com>
|
included in #130 |
rlskoeser
added a commit
that referenced
this issue
Sep 22, 2023
* Adjust panel size and placement on mobile #52 Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com> * Fix debug control panel positioning * Update colors for header/footer/panel and add panel box shadow #125 * Add phosphor icons; adjust panel styles and close button position * Revise panel styles - more semantic names for panel content sections - close button positioning/styling #84 - split out panel styles into a component csss file - make close button more accessible * Add leaf icon to branch in leaf details * Fix selected leaf hash bug * Update unit tests for changes to container names * Update visual testing selected leaf id, run in production mode * Fix icon mask size on chrome; set max height for panel on desktop * Adjust panel height and tree top margin on mobile Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com> * Revise panel styles and adjust layout * Add label to placeholder tag so it won't cause lighthouse ci to fail * Add overflow wrapping within panel text --------- Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
logic of the functionality, along with the placement and dimensions of the icon are on this figma page and can be inspected here
The icon is taken from phosphor icons
The text was updated successfully, but these errors were encountered: