Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the site title in the header #145

Closed
gissoo opened this issue Apr 10, 2023 · 1 comment
Closed

Implement the site title in the header #145

gissoo opened this issue Apr 10, 2023 · 1 comment
Assignees
@rlskoeser
Labels
🛠️ chore One-off task or update

Comments

@gissoo
Copy link
Contributor

gissoo commented Apr 10, 2023

No description provided.

rlskoeser added a commit that referenced this issue Apr 11, 2023
@rlskoeser
Preliminary work to add site title to header #145
1ae7560
rlskoeser added a commit that referenced this issue Apr 11, 2023
@rlskoeser
Set correct spacing for site title on mobile and desktop #145
28b26e6
@rlskoeser rlskoeser added the 🛠️ chore One-off task or update label Apr 11, 2023
rlskoeser added a commit that referenced this issue Apr 11, 2023
@rlskoeser @gissoo
Implement site title image (#147)
7bc7369 
* Move non-icon site images out of icon directory

* add site title to the header on desktop

* add site title to the header on mobile

* Preliminary work to add site title to header #145

* Set correct spacing for site title on mobile and desktop #145

* Update site header srcset config to match svg actual widths

* Use picture instead of srcset for responsive site title image

* Set explicit width+height on site title image per lighthouse report

---------

Co-authored-by: gissoo <44615389+gissoo@users.noreply.github.com>
@rlskoeser
Copy link
Contributor

completed in #147

rlskoeser added a commit that referenced this issue Sep 22, 2023
@rlskoeser @gissoo
Implement site title image (#147)
fc7ddbe 
* Move non-icon site images out of icon directory

* add site title to the header on desktop

* add site title to the header on mobile

* Preliminary work to add site title to header #145

* Set correct spacing for site title on mobile and desktop #145

* Update site header srcset config to match svg actual widths

* Use picture instead of srcset for responsive site title image

* Set explicit width+height on site title image per lighthouse report

---------

Co-authored-by: gissoo <44615389+gissoo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlskoeser rlskoeser

Labels
🛠️ chore One-off task or update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlskoeser @gissoo