Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create styles and guidelines for image captions/citation/titles #193

Closed
gissoo opened this issue May 9, 2023 · 8 comments
Closed

Create styles and guidelines for image captions/citation/titles #193

gissoo opened this issue May 9, 2023 · 8 comments
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented May 9, 2023

No description provided.

@gissoo gissoo added 💬 awaiting review Ready for comments and questions 🗺️ design Tracks design work in an external app labels May 9, 2023
@gissoo gissoo self-assigned this May 9, 2023
@gissoo
Copy link
Contributor Author

gissoo commented May 10, 2023

@rlskoeser @jhimpele please review the styles I have proposed based on the examples Rebecca shared with me and read the notes I have included next to each. (the image used in the mock up is not accurate)

NOTE: I was going to suggest to link the caption and/or title when possible but I think the caption with an underline will be hard to read that way if it's longer than two lines, therefore I have omitted that proposal.

@jhimpele
Copy link
Contributor

@gissoo @rlskoeser

What are the names Lossing and Barritt referring to?

Monday we decided to precede all sources with "Source:"

I don't see the last one image with only a source.

@gissoo
Copy link
Contributor Author

gissoo commented May 10, 2023

@jhimpele the name Lossing and Barritt is there in the database, it's the name of the work the source links to. I used the existing captions in the examples Rebecca shared. Here is the example with Lossing and Barritt.

Sorry about the link for the one with only a source, I fixed it, you should be able to view that page now.

@jhimpele
Copy link
Contributor

jhimpele commented May 10, 2023 via email

@rlskoeser
Copy link
Contributor

Gissoo, these look good. I like the smaller font, I think it will be more distinct than it was before.

Your suggestion for only applying a caption to the second of two images needs to be implemented on the content editing side (although I'll probably also need to adjust spacing for two figures in a row). Should we add some instructions about this to our contributor doc?

Are you proposing we add the "courtesy of" text when there is no caption but we have a source?

It's possible to have a source without a source link. Is it fine if it's just italicized and not a link?

Sorry about the weird Lossing and Barritt title, that might be one of the ones that I added when I implementing and testing the basic figure functionality. I can check the spreadsheet and see if it should be updated.

@gissoo
Copy link
Contributor Author

gissoo commented May 15, 2023

Gissoo, these look good. I like the smaller font, I think it will be more distinct than it was before.

Your suggestion for only applying a caption to the second of two images needs to be implemented on the content editing side (although I'll probably also need to adjust spacing for two figures in a row). Should we add some instructions about this to our contributor doc?

Adding instructions to our contributor doc would be great! I think:

  • it should not repeat if the caption and the source are the same, they should be written once at the bottom of the last image
  • if they have at least one thing in common (source or caption) they should be written once at the bottom of the last image and use language like "caption placeholder ... first image:source placeholder second image: source placeholder"

Are you proposing we add the "courtesy of" text when there is no caption but we have a source?

  • Yes, because when there is a link it's pretty obvious that it's the source – but without any captions it's a bit awkward – I don't feel strongly but I think it's not necessary to have "courtesy of" at all times

It's possible to have a source without a source link. Is it fine if it's just italicized and not a link?

  • Yes, it is fine, it might be better to have "courtesy of" for such cases too.

Sorry about the weird Lossing and Barritt title, that might be one of the ones that I added when I implementing and testing the basic figure functionality. I can check the spreadsheet and see if it should be updated.

@gissoo
Copy link
Contributor Author

gissoo commented May 16, 2023

  • @rlskoeser @jhimpele I added an example for when the source doesn't have a link

  • for the other recommendation I made for images that have at least one thing (caption/source) in common I can't find any examples right now in the database, but it can be documented in our contributor docs and addressed when/if such cases come up.
    It will be a smoother reading experience if any text for the images just come at the bottom of the last image in these cases.

@gissoo gissoo closed this as completed May 16, 2023
@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label May 16, 2023
@jhimpele
Copy link
Contributor

jhimpele commented May 16, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants