-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create styles and guidelines for image captions/citation/titles #193
Comments
@rlskoeser @jhimpele please review the styles I have proposed based on the examples Rebecca shared with me and read the notes I have included next to each. (the image used in the mock up is not accurate)
NOTE: I was going to suggest to link the caption and/or title when possible but I think the caption with an underline will be hard to read that way if it's longer than two lines, therefore I have omitted that proposal. |
What are the names Lossing and Barritt referring to? Monday we decided to precede all sources with "Source:" I don't see the last one image with only a source. |
@jhimpele the name Lossing and Barritt is there in the database, it's the name of the work the source links to. I used the existing captions in the examples Rebecca shared. Here is the example with Lossing and Barritt. Sorry about the link for the one with only a source, I fixed it, you should be able to view that page now. |
Thanks for explaining. Just an odd title!
|
Gissoo, these look good. I like the smaller font, I think it will be more distinct than it was before. Your suggestion for only applying a caption to the second of two images needs to be implemented on the content editing side (although I'll probably also need to adjust spacing for two figures in a row). Should we add some instructions about this to our contributor doc? Are you proposing we add the "courtesy of" text when there is no caption but we have a source? It's possible to have a source without a source link. Is it fine if it's just italicized and not a link? Sorry about the weird Lossing and Barritt title, that might be one of the ones that I added when I implementing and testing the basic figure functionality. I can check the spreadsheet and see if it should be updated. |
Adding instructions to our contributor doc would be great! I think:
|
|
Sounds and looks good Gissoo. Thanks!
On 5/16/23, 10:22 AM, "gissoo" wrote:
· @rlskoeser<https://github.com/rlskoeser> @jhimpele<https://github.com/jhimpele> I added an example<https://www.figma.com/file/sGOn9MZy6ML0yNxuiQJ8u5/Lenape-Time-Tree?type=design&node-id=1894%3A2065&t=0EcqVY6lqxlhQWqJ-1> for when the source doesn't have a link
· for the other recommendation I made for images that have at least one thing (caption/source) in common I can't find any examples right now in the database, but it can be documented in our contributor docs and addressed when/if such cases come up.
It will be a smoother reading experience if any text for the images just come at the bottom of the last image in these cases.
—
Reply to this email directly, view it on GitHub<#193 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWMVXZ3QY2L6QATAO3F52NDXGOERDANCNFSM6AAAAAAX37CZTY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
No description provided.
The text was updated successfully, but these errors were encountered: