-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trunk lines disconnected #232
Comments
@jhimpele can you share the screen size / browser size? |
@gissoo would appreciate your advice on how to handle; could we set a max height on the page for desktop? (although then it will probably look weird at the bottom of the page...). The point where the trunk lines go straight is actually the bottom of the svg proper. I extended them quite a bit to try to avoid this kind of disconnect, and could extend them even further (and add a bit more variation so they aren't as straight). |
@rlskoeser the resolution of Jeff's device seems to be 5120×2880 – maybe we should extend further, to what point are you extending them right now? |
@gissoo right now I'm extending them by 300 pixels within the svg; for context our svg viewbox is 800 pixels tall. It's trivial for me to increase that 300 number if that would be a good enough solution for now. |
@rlskoeser thanks, yes, let's increase please |
addressed in #6cda2b7 back in June |
Tree looks like it is shifted to the left a little and disconnected the Dedication strings.
The trunk itself is disconnected from roots if the browser window is too large (vertically).
The text was updated successfully, but these errors were encountered: