Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trunk lines disconnected #232

Closed
jhimpele opened this issue Jun 8, 2023 · 8 comments
Closed

Trunk lines disconnected #232

jhimpele opened this issue Jun 8, 2023 · 8 comments
Labels
🛠️ chore One-off task or update

Comments

@jhimpele
Copy link
Contributor

jhimpele commented Jun 8, 2023

  1. Tree looks like it is shifted to the left a little and disconnected the Dedication strings.

  2. The trunk itself is disconnected from roots if the browser window is too large (vertically).

Screenshot 2023-06-08 at 2 55 51 PM
@jhimpele jhimpele added the 🗺️ design Tracks design work in an external app label Jun 8, 2023
@rlskoeser
Copy link
Contributor

@jhimpele can you share the screen size / browser size?

@jhimpele
Copy link
Contributor Author

jhimpele commented Jun 8, 2023

This is a Mac Studio 27" screen. The first shot here is the full vertical extent of the screen, and the second reduces height so the trunk connects to the roots. Does the height resolution of these two images give you what you ask?
Screenshot 2023-06-08 at 3 06 04 PM
Screenshot 2023-06-08 at 3 06 40 PM

@rlskoeser
Copy link
Contributor

@gissoo would appreciate your advice on how to handle; could we set a max height on the page for desktop? (although then it will probably look weird at the bottom of the page...).

The point where the trunk lines go straight is actually the bottom of the svg proper. I extended them quite a bit to try to avoid this kind of disconnect, and could extend them even further (and add a bit more variation so they aren't as straight).

@jhimpele
Copy link
Contributor Author

At full size it seems to be displaying correctly. The other issue now is that when I reduce the height of the screen past the bend in the trunk, it falls out of alignment.
Screenshot 2023-06-12 at 10 10 08 AM

@gissoo
Copy link
Contributor

gissoo commented Jun 12, 2023

@rlskoeser the resolution of Jeff's device seems to be 5120×2880 – maybe we should extend further, to what point are you extending them right now?

@rlskoeser
Copy link
Contributor

@gissoo right now I'm extending them by 300 pixels within the svg; for context our svg viewbox is 800 pixels tall. It's trivial for me to increase that 300 number if that would be a good enough solution for now.

@gissoo
Copy link
Contributor

gissoo commented Jun 13, 2023

@rlskoeser thanks, yes, let's increase please

@gissoo gissoo removed the 🗺️ design Tracks design work in an external app label Jun 13, 2023
rlskoeser added a commit that referenced this issue Jun 13, 2023
@rlskoeser
Copy link
Contributor

addressed in #6cda2b7 back in June

@rlskoeser rlskoeser added the 🛠️ chore One-off task or update label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

3 participants