Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled leaves & labels are not sufficiently visually disabled #264

Closed
1 task done
rlskoeser opened this issue Sep 19, 2023 · 2 comments
Closed
1 task done

disabled leaves & labels are not sufficiently visually disabled #264

rlskoeser opened this issue Sep 19, 2023 · 2 comments
Assignees
Labels
♿ accessibility Impacts access for some users 🐛 bug Something isn't working

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Sep 19, 2023

accessibility review feedback from @itmaybejj:

Disabled items are not very disabled visually. E.g., at right, which items are clickable? It is hard to tell -- the color change from Ramapough to its surrounding leaves is < 3:1, but then it's not clear whether the next leaves over are in an active or disabled state.

suggestion:

Maybe modify the text as well? Gray out disabled items?

testing notes

  • confirm that labels for deselected are visually disabled/dimmed
  1. select a leaf
  2. select a tag on that leaf (may need to scroll down on the leaf detail panel)
  3. confirm that labels for leaves without that tag are dimmed (lower opacity, no text shadow)
@rlskoeser rlskoeser added the ♿ accessibility Impacts access for some users label Sep 19, 2023
@rlskoeser rlskoeser self-assigned this Nov 1, 2023
@rlskoeser rlskoeser added the 🐛 bug Something isn't working label Nov 1, 2023
@rlskoeser
Copy link
Contributor Author

looks to me that this is a bug as well as an :accessibility: fix, since there is a css selector for deselected labels; it's just that the styles weren't being applied the way we needed them to be

rlskoeser added a commit that referenced this issue Nov 1, 2023
* Gray out labels for deselected leaves #264

* Deselected leaves+labels should not be selectable on zoom #265

* Update page title when a leaf is selected #263
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Nov 1, 2023
@mnaydan
Copy link
Collaborator

mnaydan commented Nov 2, 2023

This looks fixed as well - when a leaf tag is selected, the disabled leaves no longer have the text shadow and do appear lower opacity. It looks really nice and clear.

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿ accessibility Impacts access for some users 🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants