Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a mobile user, I want a way to get back to the project introduction after I've closed it, so I can refer back to it after exploring the timetree. #85

Closed
4 tasks done
gissoo opened this issue Feb 15, 2023 · 3 comments
Assignees

Comments

@gissoo
Copy link
Contributor

gissoo commented Feb 15, 2023

implement the information icon on mobile to display the introduction panel

logic of the functionality, along with the placement and dimensions of the icon are on this figma page and can be inspected here

The icon is taken from phosphor icons

dev notes

Note: it may be worth refactoring panel-centric code into an object/component; may make it possible to get ride of some code duplication and also make it more readable (e.g. Panel.close())

revisions

  • info button enabled whenever intro panel is not visible (even if leaf details are visible)
  • info button should show intro when clicked (either closed or leaf details visible)
  • when the page is loaded with a tag but no leaf selected (i.e., coming from the tag index), the intro should not be displayed on mobile
  • collapsing the info panel should not deselect the current tag
@rlskoeser rlskoeser changed the title implement the information icon on mobile to display the introduction panel As a mobile user, I want a way to get back to the project introduction after I've closed it, so I can refer back to it after exploring the timetree. Mar 28, 2023
rlskoeser added a commit that referenced this issue Apr 11, 2023
@rlskoeser rlskoeser self-assigned this Apr 11, 2023
@rlskoeser
Copy link
Contributor

upgrading from 1pt to 2 to account for the different states that need to be handled

rlskoeser added a commit that referenced this issue Apr 18, 2023
* Implement info button for mobile #85

* Make site title a link to the homepage when not the page title (h1)

* Revise panel / info button behavior

- info button enabled when leaf details are shown
- info button should hide leaf details and show intro when clicked

* Update info panel & tag interactions

- when the page is loaded from tag index, don't show intro
- when tag is selected and no leaf, hiding intro keeps tag active

* Always close leaf details when opening intro panel

* Revise panel interactions for intro, leaf, and info button
rlskoeser added a commit that referenced this issue Apr 18, 2023
rlskoeser added a commit that referenced this issue Apr 18, 2023
rlskoeser added a commit that referenced this issue Apr 18, 2023
* Implement info button for mobile #85

* Make site title a link to the homepage when not the page title (h1)

* Revise panel / info button behavior

- info button enabled when leaf details are shown
- info button should hide leaf details and show intro when clicked

* Update info panel & tag interactions

- when the page is loaded from tag index, don't show intro
- when tag is selected and no leaf, hiding intro keeps tag active

* Always close leaf details when opening intro panel

* Revise panel interactions for intro, leaf, and info button
@rlskoeser
Copy link
Contributor

increasing to 3 pts due to the complexity of the different interactions between panel, selected leaf, selected tag, etc.

@rlskoeser
Copy link
Contributor

reviewed on #149; acceptance testing on PR #158

rlskoeser added a commit that referenced this issue Sep 22, 2023
* Implement info button for mobile #85

* Make site title a link to the homepage when not the page title (h1)

* Revise panel / info button behavior

- info button enabled when leaf details are shown
- info button should hide leaf details and show intro when clicked

* Update info panel & tag interactions

- when the page is loaded from tag index, don't show intro
- when tag is selected and no leaf, hiding intro keeps tag active

* Always close leaf details when opening intro panel

* Revise panel interactions for intro, leaf, and info button
rlskoeser added a commit that referenced this issue Sep 22, 2023
rlskoeser added a commit that referenced this issue Sep 22, 2023
* Implement info button for mobile #85

* Make site title a link to the homepage when not the page title (h1)

* Revise panel / info button behavior

- info button enabled when leaf details are shown
- info button should hide leaf details and show intro when clicked

* Update info panel & tag interactions

- when the page is loaded from tag index, don't show intro
- when tag is selected and no leaf, hiding intro keeps tag active

* Always close leaf details when opening intro panel

* Revise panel interactions for intro, leaf, and info button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants