Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want to see bibliographic information (title, publication date, publisher, link to OCLC if available) for an individual library item, so that I can more accurately identify the item. #234

Closed
rlskoeser opened this issue Apr 3, 2019 · 7 comments
Assignees
Milestone

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Apr 3, 2019

testing notes

designs

desktop / tablet / mobile

checklist

this issue has a variety of different things to test (including on the admin side). in order to support the display of a work's creators on the detail page, we added an "order" property to creator types, so that you can choose the order in which creators will be displayed (e.g. make sure authors are listed first, followed by editors, etc).

you will want to have a variety of works to test with; ideally at least one of each of:

  • a periodical with issue info ("The Dial")
  • a book with a "read online" link ("The Garden Party")
  • a book with multiple authors ("The English Novelists")
  • a book with multiple kinds of creators ("Capajon")
  • a book with public notes ("Dante")

visit each of these detail pages, and check that:

  1. all of the creators are listed and match the design
  2. the work has the correct format indicator (book, periodical)
  3. the "read online" link works
  4. the public notes are displayed
  5. the list of issues is displayed

note that the uncertainty indicator is not yet visible, since that's #524.

after you test this out, head to the admin backend and look at the creator types.

  1. you should see a new property of each creator type, "order"
  2. some of the existing creator types should automatically have an order assigned to them (for example, "author" should be 1, so that it comes first)
  3. try changing the order values around (for example, put editors first) and visit a detail page. did the order of creators change?
  4. make a new creator type (anything will do; I tested with "binder"). it should automatically receive the order value 20.
@rlskoeser rlskoeser added this to the v0.16 milestone May 13, 2019
@thatbudakguy thatbudakguy self-assigned this May 16, 2019
@thatbudakguy thatbudakguy removed this from the v0.16 milestone May 16, 2019
@thatbudakguy thatbudakguy removed their assignment May 16, 2019
@rlskoeser rlskoeser added this to the v0.28 milestone Mar 25, 2020
@thatbudakguy thatbudakguy self-assigned this Mar 30, 2020
@thatbudakguy
Copy link
Contributor

bumping to a 5 because this required model changes and there were no view tests.

@clmahoney
Copy link

clmahoney commented Apr 3, 2020

Desktop:

  • YES, I checked periodical "transition," saw everything I should be seeing (all of the creators are listed and match the design; the work has the correct format indicator (book, periodical); the list of issues is displayed)
    Screen Shot 2020-04-03 at 12 46 19 PM

  • YES, when I checked "The Garden Party" and had added an ebook link, I was able to click through the link and get to the Project Gutenberg version

  • YES, when I checked the multiple author book "The English Novelists," I DID see the multiple authors but I did NOT see the differentiation of "Book":
    Screen Shot 2020-04-03 at 12 51 12 PM

  • YES, when I checked the multiple creator "Capajon," I DID see the multiple creators but did NOT see the "Book" box:
    Screen Shot 2020-04-03 at 12 52 14 PM

  • YES, a book with a public note shows the public note. I checked "Dante," and I had put in a test public note:
    Screen Shot 2020-04-03 at 12 54 35 PM

@clmahoney
Copy link

Mobile:

  • YES, periodical shows issues and "Periodical" format (tried "transition" and "New Masses"
  • YES, a book with a "read online" link works - I tried "The Garden Party"
  • YES, a book with multiple authors show all authors. I tried "A History of Sculpture."
  • YES, a book with multiple kinds of creators shows all creators. I tried "Capajon," and saw the multiple authors, the introduction writer, and the translator.
  • YES, a book with public notes shows the public note. I checked "Dante" again.
  • YES,

@clmahoney
Copy link

Tablet:

  • All looks good here too!

@clmahoney
Copy link

Admin backend of Creator Types:

  • YES, I see the "Order" of the creator types:
    Screen Shot 2020-04-03 at 1 32 53 PM
  • YES, I see the designated order (see above screenshot)
  • YES, when I changed the order and then went to a detail page, the order that I created showed up. I made Introduction Add chatops QA deploy #1, and that was how it was in the book detail page. For some reason thought it took forever for the page to save and load again when I changed the order. But then I did a hard refresh and it was faster!
  • NO, when I tried to add a new creator type, it wouldn't save without me manually entering in an order. Then when I entered an order # of 7, it ordered it alphabetically:
    Screen Shot 2020-04-03 at 1 39 16 PM

@thatbudakguy
Copy link
Contributor

thatbudakguy commented Apr 6, 2020

@clmahoney I actually wrote the notes wrong on this - the behavior you saw is the correct one! sorry about that.

what should happen is:

  • when you create a new creator type, you have to specify its order (but any number is fine; duplicates are OK)
  • if there were any "extra" creator types existing before this update (i.e. beyond author, editor, etc) they would get a default value of 20 (because they're not allowed to be blank) and then you could change them later if you wanted. but it appears we anticipated all the existing types, so this didn't happen. which is fine!

the alphabetic ordering is because "name" is chosen for ordering by default on this page; if you click the "order" column it will order by the order values instead. if it makes more sense to order them here the same way we order them on the book detail page, I think that would be an easy change to make.

@clmahoney
Copy link

@thatbudakguy I see, thank you for explaining! Then this looks good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants